[mantisbt-commits] [mantisbt/mantisbt] 5831eb: Whitespace

[GitHub <no...@gi...>]

  Branch: refs/heads/master-1.3.x
  Home:   https://github.com/mantisbt/mantisbt
  Commit: 5831eb3442829d16f2557c1c283c67f3c9525428
      https://github.com/mantisbt/mantisbt/commit/5831eb3442829d16f2557c1c283c67f3c9525428
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M core/classes/ConfigParser.class.php
    M core/classes/Tokenizer.class.php
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Whitespace


  Commit: e0e7924b4b0bfd1dc511fa7e6d7a81168a734ac6
      https://github.com/mantisbt/mantisbt/commit/e0e7924b4b0bfd1dc511fa7e6d7a81168a734ac6
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Config tests: add no tokens case


  Commit: afdd002a84f3fe37649a99d04e404d2fdcd082e0
      https://github.com/mantisbt/mantisbt/commit/afdd002a84f3fe37649a99d04e404d2fdcd082e0
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Config tests: add cases for '0' and '' (issue #21124)


  Commit: d6d526c89b5d066430dcc4763788bda05b115e78
      https://github.com/mantisbt/mantisbt/commit/d6d526c89b5d066430dcc4763788bda05b115e78
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Use data provider for ScalarTypes tests


  Commit: 699095627826887a5eb4458c55751eb03ddf5d42
      https://github.com/mantisbt/mantisbt/commit/699095627826887a5eb4458c55751eb03ddf5d42
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Use data provider for Array tests


  Commit: 093ea44f04187504cccf6cee5dca8a0b57e40918
      https://github.com/mantisbt/mantisbt/commit/093ea44f04187504cccf6cee5dca8a0b57e40918
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M core/classes/ConfigParser.class.php
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Config tests: add cases for negative/positive numbers


  Commit: 9636642ae550072fb876468c818acdc45ed04718
      https://github.com/mantisbt/mantisbt/commit/9636642ae550072fb876468c818acdc45ed04718
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M core/classes/Tokenizer.class.php

  Log Message:
  -----------
  Tokenizer: no exception in constructor when given empty string

An empty string is a valid code snippet and as such should not trigger
an exception. Doing so forces the caller to perform additional error
handling.

Fixes #21124


  Commit: b1173d8050082f968e3c91d92dd4d819df0f8d84
      https://github.com/mantisbt/mantisbt/commit/b1173d8050082f968e3c91d92dd4d819df0f8d84
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M adm_config_set.php

  Log Message:
  -----------
  Improve handling of empty values in adm_config_set.php

When processing an empty value, the code now evaluates the config type
as if user had selected 'default'; this ensures the proper case of
'empty' is used depending on the config being set (i.e. 0, '').

We also avoid calling the config parser in this case, because a simple
typecast is sufficient to process user input.

Fixes #21124


  Commit: 7bbf2ea48c5a214bc4ec44669626fa596a07345c
      https://github.com/mantisbt/mantisbt/commit/7bbf2ea48c5a214bc4ec44669626fa596a07345c
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M adm_config_report.php

  Log Message:
  -----------
  Avoid config values corruption when editing them

Prior to this, an nl2br() conversion was systematically performed when
displaying the config option. This caused insertion of '<br />' tags
when editing configs containing newlines, which would then be saved.

We now only perform the nl2br conversion when the config is printed for
display.

Fixes #21136


  Commit: 5484d10d49e474e848cea806cabe76bbc8895538
      https://github.com/mantisbt/mantisbt/commit/5484d10d49e474e848cea806cabe76bbc8895538
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M core/classes/Tokenizer.class.php

  Log Message:
  -----------
  Fix Exception message outputting variable name instead of value


  Commit: 9ed0b9f5d1f984bc33e42325d0fa2fa9fbc22ac5
      https://github.com/mantisbt/mantisbt/commit/9ed0b9f5d1f984bc33e42325d0fa2fa9fbc22ac5
  Author: Damien Regad <dr...@ma...>
  Date:   2016-07-03 (Sun, 03 Jul 2016)

  Changed paths:
    M adm_config_report.php
    M adm_config_set.php
    M core/classes/ConfigParser.class.php
    M core/classes/Tokenizer.class.php
    M tests/Mantis/ConfigParserTest.php

  Log Message:
  -----------
  Fix config parsing issues and improve unit tests

PR https://github.com/mantisbt/mantisbt/pull/796

Fixes #21124, #21136


Compare: https://github.com/mantisbt/mantisbt/compare/4dcb16cc9011...9ed0b9f5d1f9