[mantisbt-commits] [mantisbt/mantisbt] 17c05b: Fixing api_token table structure

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/mantisbt/mantisbt
  Commit: 17c05b5d6dfe6271a70bbf6cf69d482302149921
      https://github.com/mantisbt/mantisbt/commit/17c05b5d6dfe6271a70bbf6cf69d482302149921
  Author: Damien Regad <dr...@ma...>
  Date:   2016-06-11 (Sat, 11 Jun 2016)

  Changed paths:
    M admin/schema.php

  Log Message:
  -----------
  Fixing api_token table structure

After careful review following @grangeway's comment in PR 685 [1]:

- user_id field should be *unsigned* int
- default value for varchar columns should be ''
- default value for date fields should be 1 not 0

[1] https://github.com/mantisbt/mantisbt/pull/685#discussion_r48686670

Fixes #20472


  Commit: 1f678c2afce4275fc396f3757a0db20d8f1b89fa
      https://github.com/mantisbt/mantisbt/commit/1f678c2afce4275fc396f3757a0db20d8f1b89fa
  Author: Damien Regad <dr...@ma...>
  Date:   2016-06-11 (Sat, 11 Jun 2016)

  Changed paths:
    M api_tokens_page.php
    M core/api_token_api.php

  Log Message:
  -----------
  New api_token_is_used() function

Move the logic to determine whether a token has been used from
api_tokens_page.php to the api_tokens API where it belongs.

The check against date_used has been changed from '=== 0' to '<= 1' to
reflect the change in schema definition in step 206.

Fixes #20472


  Commit: 4be5f2289b50533f7c6c0ebbbde87dbd1225501c
      https://github.com/mantisbt/mantisbt/commit/4be5f2289b50533f7c6c0ebbbde87dbd1225501c
  Author: Damien Regad <dr...@ma...>
  Date:   2016-06-11 (Sat, 11 Jun 2016)

  Changed paths:
    M admin/schema.php

  Log Message:
  -----------
  Revert 'name' and 'hash' columns to original definition

Following discussion in PR https://github.com/mantisbt/mantisbt/pull/700

Fixes #20472


  Commit: 28310c2e4b0be7e1ffea0b53bdece924df6ce32f
      https://github.com/mantisbt/mantisbt/commit/28310c2e4b0be7e1ffea0b53bdece924df6ce32f
  Author: Damien Regad <dr...@ma...>
  Date:   2016-06-11 (Sat, 11 Jun 2016)

  Changed paths:
    M admin/schema.php
    M api_tokens_page.php
    M core/api_token_api.php

  Log Message:
  -----------
  Merge branch 'token_api-fixes'

Fixes https://github.com/mantisbt/mantisbt/pull/700


Compare: https://github.com/mantisbt/mantisbt/compare/76cb1ad26ed0...28310c2e4b0b