From: Louis B. <lba...@gm...> - 2014-10-21 10:56:16
|
I applied the pache descriped in issue 13056. This patch works "a little" : most URLs are correct, there are bad urls when a user disconnects and reconnects on a page that is not the root https://host/mantis. The email pb is because the patch sets $gpath to empty string. Therefore, string_get_confirm_hash_url cannot return a complete URL. ----------------- patch applied form 13056: Mantis\config_inc.php line 13 // modif proxy $g_path = ''; $t_url = ''; Mantis\core\string_api.php line 292 //return $t_path . '/' . $t_script . $t_query . $t_anchor; // modif proxy return $t_path . $t_script . $t_query . $t_anchor; Mantis\core\helper_api.php line 482 //return config_get_global( 'short_path' ) . $p_url; // modif proxy return $p_url; Louis BAYLE Tel: +33 (0)4.42.604.734 lba...@gm... On Sun, Oct 19, 2014 at 12:25 PM, P Richards <pa...@ma...> wrote: > In what bit of the generated email? > > > > From what I can see at first glance (in master at least): > > > > function string_get_confirm_hash_url( $p_user_id, $p_confirm_hash ) { > > $t_path = config_get( 'path' ); > > return $t_path . 'verify.php?id=' . string_url( $p_user_id > ) . '&confirm_hash=' . string_url( $p_confirm_hash ); > > } > > We always make use of config_get(‘path’) to get the value > > > > Paul > > > > *From:* Louis BAYLE [mailto:lba...@gm...] > *Sent:* 19 October 2014 09:29 > > *To:* developer discussions > *Subject:* Re: [mantisbt-dev] Mantis not working behind a reverse-proxy > > > > also, I had to hardcode the path in the login confirmation email, as there > is no way for mantis to know the external URL. > > > Louis BAYLE > Tel: +33 (0)4.42.604.734 > lba...@gm... > > > > On Sun, Oct 19, 2014 at 10:26 AM, Louis BAYLE <lba...@gm...> > wrote: > > In deed, we have mantis listening internal on http://172.x.x.x and > accessible on the external with https://88.x.x.x (the reverse-proxy). > > I'm fine if users access only via https, that's what I did for CodevTT. > I'll try the $g_path patch asap. > > > > > Louis BAYLE > Tel: +33 (0)4.42.604.734 > lba...@gm... > > > > On Sun, Oct 19, 2014 at 1:06 AM, P Richards <pa...@ma...> wrote: > > If I’m correct about what the issue is likely to be, the problem might > actually be ‘worse’ in 1.3-dev – however unless I’m mistaken here: > > > > Unless you are saying that the INTERNAL and EXTERNAL path to mantis is > different, it should be a case of setting $g_path to the final path: > > > > $g_path = $t_protocol . '://' . $t_host . $t_path; > > > > i.e. > > > > if you have mantis listening on http, with a loadbalancing reverse proxy > in front running https, whilst Mantis will detect http://www.foo.com, if > you set > > > > $g_path = https://www.foo.com in the config file that should work I > believe. > > > > > > If you are saying that you use http://mantis.internal and www.foo.org > depending on whether users are internal or external to the corporate > network, then this might be more of an issue. > > > > Looking at the code, we seem to generate a mixture of absolute and > relative links within a page in both 1.2 and 1.3 – the $g_path fix should > be fine for the reverse proxy case, however, the absolute links will need > to go to deal with the split-dns case. > > > > Paul > > > > > > *From:* Louis BAYLE [mailto:lba...@gm...] > *Sent:* 18 October 2014 23:16 > *To:* developer discussions > *Subject:* Re: [mantisbt-dev] Mantis not working behind a reverse-proxy > > > > Yes, I can install a mantis 1.3-dev on our server and test it. > > I'm not sure I'll have time to do that next week, but I'll let you know. > > > Louis BAYLE > Tel: +33 (0)4.42.604.734 > lba...@gm... > > > > On Sat, Oct 18, 2014 at 11:55 PM, Paul Richards < > gra...@bl...> wrote: > > Are you able to test if the situation is any better with 1.3-dev? > > > > If this is an absolute vs relative link type issue, (which I’m guessing it > is) I’m not sure if the situation is improved in 1.3 > > > > Paul > > > > *From:* Louis BAYLE [mailto:lba...@gm...] > *Sent:* 18 October 2014 22:44 > *To:* developer discussions > *Subject:* [mantisbt-dev] Mantis not working behind a reverse-proxy > > > > Is there a 'good patch' to fix this realy problematic bug in Mantis ? > > The patch I applied to our installation does not work very well. > IMHO this is realy a critical bug. > > > http://www.mantisbt.org/bugs/view.php?id=13056 > http://www.mantisbt.org/bugs/view.php?id=9333 > > Louis BAYLE > Tel: +33 (0)4.42.604.734 > lba...@gm... > > > > ------------------------------------------------------------------------------ > Comprehensive Server Monitoring with Site24x7. > Monitor 10 servers for $9/Month. > Get alerted through email, SMS, voice calls or mobile push notifications. > Take corrective actions from your mobile device. > http://p.sf.net/sfu/Zoho > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > > > > > ------------------------------------------------------------------------------ > Comprehensive Server Monitoring with Site24x7. > Monitor 10 servers for $9/Month. > Get alerted through email, SMS, voice calls or mobile push notifications. > Take corrective actions from your mobile device. > http://p.sf.net/sfu/Zoho > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > > > > > > ------------------------------------------------------------------------------ > Comprehensive Server Monitoring with Site24x7. > Monitor 10 servers for $9/Month. > Get alerted through email, SMS, voice calls or mobile push notifications. > Take corrective actions from your mobile device. > http://p.sf.net/sfu/Zoho > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > |