Re: [mantisbt-dev] EVENT_MANAGE_PROJECT_DELETE

[Louis B. <lba...@gm...>]

Hi Paul,
I too, created a pull request on EVENT_MANAGE_PROJECT_DELETED:
https://github.com/mantisbt/mantisbt/pull/383

So now we've got two :-)

Note: i called it "..._DELETED" (instead of "..._DELETE", to be similar to
the  'EVENT_BUG_DELETED' event. But it's exactly the same code.

I tested in on my plugin, so it should be ok.

Thank you,
Louis

Louis BAYLE
Tel: +33 (0)4.42.604.734
lba...@gm...

On Thu, Oct 16, 2014 at 9:16 PM, Paul Richards <gra...@bl...>
wrote:

> Louis,
>
>
>
> As promised, I’ve generated the patch I had for PROJECT event deletion,
> and also VERSION event deletion.
>
>
>
> Whilst I managed to generate the patch at lunchtime today from previous
> experimental branches, we block SSH from our work network to “unknown”
> hosts so could only generate the PR now.
>
>
>
> I’ve created two bugs in Mantis to track these new events:
>
>
>
> http://www.mantisbt.org/bugs/view.php?id=17782 - 0017782: New Event:
> EVENT_MANAGE_VERSION_DELETE
>
> http://www.mantisbt.org/bugs/view.php?id=17783 - 0017783: New Event:
> EVENT_MANAGE_PROJECT_DELETE
>
>
>
> Can you see if the PR for this at
> https://github.com/mantisbt/mantisbt/pull/384  would achieve what you
> were after?
>
>
>
> I’ve got some similar patches still to generate PR’s for, so if there’s
> anything else you are missing say – it might be I already have a patch, or
> it might be something new that it would be helpful for you to work on
> implementing.
>
>
>
> Thanks
>
> Paul
>
>
>
> *From:* Paul Richards [mailto:pa...@ma...]
> *Sent:* 16 October 2014 10:08
> *To:* developer discussions
> *Subject:* Re: [mantisbt-dev] EVENT_MANAGE_PROJECT_DELETE
>
>
>
> Hi Louis,
>
>
>
> I'd been reviewing some of the EVENT's in mantis recently for correct
> placement.
>
>
>
> Hooks on deleting project is one of the areas where we are missing events.
>
>
>
> I'll generate a PR either during a spare moment today or this evening for
> this. We actually miss being able to hook on a number of deletion
> activities across the code base - adding additional hooks to cover this is
> something that has been on my list to backport from the previous scrapped
> 2.x branches.
>
>
>
> In addition, when reviewing the events before in that branch, there were a
> number of events that I believe we mis-placed within the code base ( some
> of which are currently in as PR's and as those get reviewed and merged,
> i'll be continuing to submit the remaining ones)
>
>
>
> Paul
>
>
>
>
>
>
>
> On Thu, Oct 16, 2014 at 9:27 AM, Louis BAYLE <lba...@gm...>
> wrote:
>
> Hi,
>
> I have not found any EVENT_MANAGE_PROJECT_DELETE in core/events_inc.php.
>
> Do you know if someone has already worked on this ?
>
> If not, I'll try to do it. Is there any chance that this would be
> integrated in future mantis 1.2.x releases or are you not interested in
> this event ?
>
>
>
> Is there any documentation on adding events in mantis ?
>
> Best regards,
>
>
> Louis BAYLE
> http://CodevTT.org
> lba...@gm...
>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> mantisbt-dev mailing list
> man...@li...
> https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
>
>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> mantisbt-dev mailing list
> man...@li...
> https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
>
>