Menu
▾
▴
mantisbt-help
|
From: Fabian C. <Cen...@in...> - 2017-11-07 10:07:06
|
Hi I'm still using the old 1.3 version with the SourceControl plugin. I'm having a problem that someone might know what's going on. I have repositories configured, they have a hook, upon a commit the SourceControl is called and the changesets are imported, so far so good. However the closing of bugs mentioned in the commit message does not work. The number is parsed and the changeset is added so the RegEx and the text are fine. I also get the commit message and mail with the "Bug Fixed Message" setting. I also have the "Resolve Fixed Issues" checked and "Bug Fixed Status"=closed and "Bug Fixed Resolution"=fixed. The RegExes are all on default, the message is "! Fixed #1234: ..." After committing and getting the mail I check the issue in Mantis and it is still open/confirmed. What else can go wrong or could I check to make it work? Thanks bye Fabi |
|
From: Fabian C. <Cen...@in...> - 2017-11-09 11:29:30
|
At 10:54 07.11.2017, you wrote: >Hi > >I'm still using the old 1.3 version with the SourceControl >plugin. I'm having a problem that someone might know >what's going on. > >I have repositories configured, they have a hook, upon >a commit the SourceControl is called and the changesets >are imported, so far so good. >However the closing of bugs mentioned in the commit >message does not work. The number is parsed and >the changeset is added so the RegEx and the text are >fine. I also get the commit message and mail with the >"Bug Fixed Message" setting. I also have the "Resolve >Fixed Issues" checked and "Bug Fixed Status"=closed >and "Bug Fixed Resolution"=fixed. The RegExes are >all on default, the message is "! Fixed #1234: ..." >After committing and getting the mail I check the issue >in Mantis and it is still open/confirmed. > >What else can go wrong or could I check to make it work? How can I debug this myself? What LogLevels are used in the SourceControl plugin? Thanks bye Fabi |
|
From: Fabian C. <Cen...@in...> - 2017-11-13 07:33:10
|
At 12:29 09.11.2017, you wrote: >At 10:54 07.11.2017, you wrote: >>Hi >> >>I'm still using the old 1.3 version with the SourceControl >>plugin. I'm having a problem that someone might know >>what's going on. >> >>I have repositories configured, they have a hook, upon >>a commit the SourceControl is called and the changesets >>are imported, so far so good. >>However the closing of bugs mentioned in the commit >>message does not work. The number is parsed and >>the changeset is added so the RegEx and the text are >>fine. I also get the commit message and mail with the >>"Bug Fixed Message" setting. I also have the "Resolve >>Fixed Issues" checked and "Bug Fixed Status"=closed >>and "Bug Fixed Resolution"=fixed. The RegExes are >>all on default, the message is "! Fixed #1234: ..." >>After committing and getting the mail I check the issue >>in Mantis and it is still open/confirmed. >> >>What else can go wrong or could I check to make it work? > >How can I debug this myself? What LogLevels are used in >the SourceControl plugin? i added some debug code to see what's going on. I found out that Source.API.php checks for PVM and skips the closing if this is not available and enabled. PVM is the product-version- matrix plugin. Why is this needed? Can't I just close bugs in mantis without this plugin? Is it enough to just install and enable it or does it have more dependencies? Does it need configuration if I don't use it? Thanks bye Fabi |
|
From: Fabian C. <Cen...@in...> - 2017-11-13 11:57:35
|
>i added some debug code to see what's going on. I found out
>that Source.API.php checks for PVM and skips the closing
>if this is not available and enabled. PVM is the product-version-
>matrix plugin. Why is this needed? Can't I just close bugs in
>mantis without this plugin? Is it enough to just install and enable
>it or does it have more dependencies? Does it need configuration
>if I don't use it?
Even though I'm only talking to myself here: I think I now found
the real problem, nothing to do with PVM. There's a setting stored
in the database under 'plugin_Source_bugfix_handler'. In the config
page this is the option 'Bug Fixed Assign To Committer'. I unchecked
this because I didn't want to change any data in the bug, I only want
it to be closed if the commit message contains 'Fixed #...' That's when
the automatic closing stopped.
In Source.API.php this variable is checked if it is set.
$t_handler = config_get( 'plugin_Source_bugfix_handler' );
if ( Source_PVM() ) {
...
} elseif( $t_handler && $t_handler_id !== null ) {
...close bug
}
So it seems that auto closing is not possible if this setting is not
enabled. As I don't want to change the handler in the bug I will either
skip the check for the setting or disable the code to change the bug
handler. I find it wrong to disable closing completely if this handler
is not set in the config. And it looks like the current code in git is
still the same.
Are there reasons to do it like that? Am I missing something?
Thanks
bye Fabi
|
|
From: Damien R. <dr...@ma...> - 2017-11-13 14:40:49
|
Fabian Cenedese <Cen...@in...> wrote:
>
>> i added some debug code to see what's going on. I found out
>> that Source.API.php checks for PVM and skips the closing
>> if this is not available and enabled. PVM is the product-version-
>> matrix plugin. Why is this needed? Can't I just close bugs in
>> mantis without this plugin? Is it enough to just install and enable
>> it or does it have more dependencies? Does it need configuration
>> if I don't use it?
>
> Even though I'm only talking to myself here: I think I now found
> the real problem, nothing to do with PVM. There's a setting stored
> in the database under 'plugin_Source_bugfix_handler'. In the config
> page this is the option 'Bug Fixed Assign To Committer'. I unchecked
> this because I didn't want to change any data in the bug, I only want
> it to be closed if the commit message contains 'Fixed #...' That's when
> the automatic closing stopped.
>
> In Source.API.php this variable is checked if it is set.
>
> $t_handler = config_get( 'plugin_Source_bugfix_handler' );
> if ( Source_PVM() ) {
> ...
> } elseif( $t_handler && $t_handler_id !== null ) {
> ...close bug
> }
>
> So it seems that auto closing is not possible if this setting is not
> enabled. As I don't want to change the handler in the bug I will either
> skip the check for the setting or disable the code to change the bug
> handler. I find it wrong to disable closing completely if this handler
> is not set in the config. And it looks like the current code in git is
> still the same.
>
> Are there reasons to do it like that? Am I missing something?
Hello Fabian
Sorry I hardly follow this mailing list anymore since there is so little
traffic on it. I suggest you head to GitHub for source integration plug-in
support.
https://github.com/mantisbt-plugins/source-integration
Feel free to open a new issue if you feel the plug-ins behavior is
incorrect.
|
|
From: Fabian C. <Cen...@in...> - 2017-11-14 08:18:08
|
>Hello Fabian > >Sorry I hardly follow this mailing list anymore since there is so little >traffic on it. I suggest you head to GitHub for source integration plug-in >support. > >https://github.com/mantisbt-plugins/source-integration > >Feel free to open a new issue if you feel the plug-ins behavior is >incorrect. Okay, I added a comment to this issue which talks about the same settings and probably is the same problem https://github.com/mantisbt-plugins/source-integration/issues/229 bye Fabi |
Thanks for helping keep SourceForge clean.
X