From: Robert M. <rob...@gm...> - 2015-07-30 07:58:40
|
Hi, In MantisBT 1.2 jQuery was provided by a plugin. In MantisBT 1.3 it's included in the core. However, there are still plugins which require jQuery. To make it easier to support both MantisBT 1.2 and 1.3 in plugins we could 'provide' a dummy jQuery plugin with the MantisBT core. Thoughts? Robert |
From: Roland B. <ro...@at...> - 2015-08-02 08:45:23
|
Consider also https://www.mantisbt.org/bugs/view.php?id=17360 and https://github.com/mantisbt/mantisbt/pull/239 when thinking about it I prefer breaking things instead of some magic in the background that might finally end in strange issues. Of course, I am biased as I am quite often dealing with strange issues in our forum ;-) Roland > Robert Munteanu <rob...@gm...> hat am 30. Juli 2015 um 09:58 > geschrieben: > > > Hi, > > In MantisBT 1.2 jQuery was provided by a plugin. In MantisBT 1.3 it's > included in the core. However, there are still plugins which require > jQuery. > > To make it easier to support both MantisBT 1.2 and 1.3 in plugins we > could 'provide' a dummy jQuery plugin with the MantisBT core. > > Thoughts? > > Robert > > ------------------------------------------------------------------------------ > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev |
From: Damien R. <dr...@ma...> - 2015-08-02 19:37:05
|
On 2015-08-02 10:32, Roland Becker wrote: >> Robert Munteanu <rob...@gm...> hat am 30. Juli 2015 um 09:58 >> geschrieben: >> >> To make it easier to support both MantisBT 1.2 and 1.3 in plugins we >> could 'provide' a dummy jQuery plugin with the MantisBT core. >> >> Thoughts? > > I prefer breaking things instead of some magic in the background that might > finally end in strange issues. I'm with Roland here. I believe the system I've put in place quite effectively deals with the problem by disabling the plugin; this should force the plugin authors to have a look at their code, and implement any necessary changes to ensure proper operations with 1.3 and release a specific version. I'm aware that this approach does put an additional burden on the plugin authors (to maintain a dedicated 1.3 branch), but in my opinion it is a better and safer alternative than the "dummy plugin" you suggest which would anyway only cover part of the 1.3 compatibility problem. In addition to jQuery support, authors also need to consider the revised CSS, deprecated functions, new syntax for DB queries, etc. |
From: Robert M. <rob...@gm...> - 2015-08-07 13:15:33
|
On Sun, Aug 2, 2015 at 10:36 PM, Damien Regad <dr...@ma...> wrote: > On 2015-08-02 10:32, Roland Becker wrote: >>> Robert Munteanu <rob...@gm...> hat am 30. Juli 2015 um 09:58 >>> geschrieben: >>> >>> To make it easier to support both MantisBT 1.2 and 1.3 in plugins we >>> could 'provide' a dummy jQuery plugin with the MantisBT core. >>> >>> Thoughts? >> >> I prefer breaking things instead of some magic in the background that might >> finally end in strange issues. > > I'm with Roland here. > > I believe the system I've put in place quite effectively deals with the > problem by disabling the plugin; this should force the plugin authors to > have a look at their code, and implement any necessary changes to ensure > proper operations with 1.3 and release a specific version. > > I'm aware that this approach does put an additional burden on the plugin > authors (to maintain a dedicated 1.3 branch), but in my opinion it is a > better and safer alternative than the "dummy plugin" you suggest which > would anyway only cover part of the 1.3 compatibility problem. > > In addition to jQuery support, authors also need to consider the revised > CSS, deprecated functions, new syntax for DB queries, etc. So the answer is no, we should not 'provide' jQuery :-) Thanks, Robert -- http://robert.muntea.nu/ |