From: Paul R. <pa...@ma...> - 2013-09-08 12:11:07
|
I'm looking at bug copy, and thinking the bit in bold below could be removed: At the moment, when we 'copy' a bug, we also copy the attachments on disk, creating duplicates - this seems somewhat silly, as it's the same file, or am I missing a reason for this? # Copy attachments if( $p_copy_attachments ) { while( $t_bug_file = db_fetch_array( $t_result ) ) { * # prepare the new diskfile name and then copy the file* * $t_file_path = dirname( $t_bug_file['folder'] );* * $t_new_diskfile_name = $t_file_path . file_generate_unique_name( 'bug-' . $t_bug_file['filename'], $t_file_path );* * $t_new_file_name = file_get_display_name( $t_bug_file['filename'] );* * if(( config_get( 'file_upload_method' ) == DISK ) ) {* * copy( $t_bug_file['diskfile'], $t_new_diskfile_name );* * chmod( $t_new_diskfile_name, config_get( 'attachments_file_permissions' ) );* * }* $t_query = "INSERT INTO {bug_file} ( bug_id, title, description, diskfile, filename, folder, filesize, file_type, date_added, content ) VALUES ( %d, %s, %s, %s, %s, %s, %d, %s, %d, %d)"; db_query( $t_query, array( $t_new_bug_id, $t_bug_file['title'], $t_bug_file['description'], $t_new_diskfile_name, $t_new_file_name, $t_bug_file['folder'], $t_bug_file['filesize'], $t_bug_file['file_type'], $t_bug_file['date_added'], $t_bug_file['content'] ) ); } } |
From: Roland B. <ro...@at...> - 2013-09-08 12:29:52
|
If you don't have duplicate files you have to check for references to the file when deleting issues and when deleting attachments. You have to create a duplicate if you copy from project 1 to project 2 if project 2 has a different configurations for the upload folder. > Paul Richards <pa...@ma...> hat am 8. September 2013 um 14:10 > geschrieben: > > > I'm looking at bug copy, and thinking the bit in bold below could be > removed: > > At the moment, when we 'copy' a bug, we also copy the attachments on disk, > creating duplicates - this seems somewhat silly, as it's the same file, or > am I missing a reason for this? > > # Copy attachments > if( $p_copy_attachments ) { > while( $t_bug_file = db_fetch_array( $t_result ) ) { > > * # prepare the new diskfile name and then copy the file* > * $t_file_path = dirname( $t_bug_file['folder'] );* > * $t_new_diskfile_name = $t_file_path . file_generate_unique_name( 'bug-' . > $t_bug_file['filename'], $t_file_path );* > * $t_new_file_name = file_get_display_name( $t_bug_file['filename'] );* > * if(( config_get( 'file_upload_method' ) == DISK ) ) {* > * copy( $t_bug_file['diskfile'], $t_new_diskfile_name );* > * chmod( $t_new_diskfile_name, config_get( 'attachments_file_permissions' ) > );* > * }* > > $t_query = "INSERT INTO {bug_file} > ( bug_id, title, description, diskfile, filename, folder, filesize, > file_type, date_added, content ) > VALUES ( %d, %s, %s, %s, %s, %s, %d, %s, %d, %d)"; > db_query( $t_query, array( $t_new_bug_id, $t_bug_file['title'], > $t_bug_file['description'], $t_new_diskfile_name, $t_new_file_name, > $t_bug_file['folder'], $t_bug_file['filesize'], $t_bug_file['file_type'], > $t_bug_file['date_added'], $t_bug_file['content'] ) ); > } > } > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk_______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev |
From: Paul R. <pa...@ma...> - 2013-09-08 12:37:58
|
Fair point on 1 - I wonder if we would be better checking for references then duplicating content though. Regarding number 2, bug_copy is already broken as we don't call file_normalize_attachment_path. On Sun, Sep 8, 2013 at 1:29 PM, Roland Becker <ro...@at...> wrote: > > If you don't have duplicate files you have to check for references to the > file > when deleting issues and when deleting attachments. > > You have to create a duplicate if you copy from project 1 to project 2 if > project 2 has a different configurations for the upload folder. > > > Paul Richards <pa...@ma...> hat am 8. September 2013 um 14:10 > > geschrieben: > > > > > > I'm looking at bug copy, and thinking the bit in bold below could be > > removed: > > > > At the moment, when we 'copy' a bug, we also copy the attachments on > disk, > > creating duplicates - this seems somewhat silly, as it's the same file, > or > > am I missing a reason for this? > > > > # Copy attachments > > if( $p_copy_attachments ) { > > while( $t_bug_file = db_fetch_array( $t_result ) ) { > > > > * # prepare the new diskfile name and then copy the file* > > * $t_file_path = dirname( $t_bug_file['folder'] );* > > * $t_new_diskfile_name = $t_file_path . file_generate_unique_name( > 'bug-' . > > $t_bug_file['filename'], $t_file_path );* > > * $t_new_file_name = file_get_display_name( $t_bug_file['filename'] );* > > * if(( config_get( 'file_upload_method' ) == DISK ) ) {* > > * copy( $t_bug_file['diskfile'], $t_new_diskfile_name );* > > * chmod( $t_new_diskfile_name, config_get( > 'attachments_file_permissions' ) > > );* > > * }* > > > > $t_query = "INSERT INTO {bug_file} > > ( bug_id, title, description, diskfile, filename, folder, filesize, > > file_type, date_added, content ) > > VALUES ( %d, %s, %s, %s, %s, %s, %d, %s, %d, %d)"; > > db_query( $t_query, array( $t_new_bug_id, $t_bug_file['title'], > > $t_bug_file['description'], $t_new_diskfile_name, $t_new_file_name, > > $t_bug_file['folder'], $t_bug_file['filesize'], $t_bug_file['file_type'], > > $t_bug_file['date_added'], $t_bug_file['content'] ) ); > > } > > } > > > ------------------------------------------------------------------------------ > > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > > Discover the easy way to master current and previous Microsoft > technologies > > and advance your career. Get an incredible 1,500+ hours of step-by-step > > tutorial videos with LearnDevNow. Subscribe today and save! > > > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk_______________________________________________ > > mantisbt-dev mailing list > > man...@li... > > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > |
From: Roland B. <ro...@at...> - 2013-09-08 12:56:11
|
If you think about eliminating duplicate files on disk you should also think about eliminating blobs in database. Having different approaches is a bit confusing. Quite old known bug in bug_copy http://www.mantisbt.org/bugs/view.php?id=9489 > Paul Richards <pa...@ma...> hat am 8. September 2013 um 14:37 > geschrieben: > > > Fair point on 1 - I wonder if we would be better checking for references > then duplicating content though. > > Regarding number 2, bug_copy is already broken as we don't > call file_normalize_attachment_path. > > > > > On Sun, Sep 8, 2013 at 1:29 PM, Roland Becker <ro...@at...> wrote: > > > > > If you don't have duplicate files you have to check for references to the > > file > > when deleting issues and when deleting attachments. > > > > You have to create a duplicate if you copy from project 1 to project 2 if > > project 2 has a different configurations for the upload folder. > > > > > Paul Richards <pa...@ma...> hat am 8. September 2013 um 14:10 > > > geschrieben: > > > > > > > > > I'm looking at bug copy, and thinking the bit in bold below could be > > > removed: > > > > > > At the moment, when we 'copy' a bug, we also copy the attachments on > > disk, > > > creating duplicates - this seems somewhat silly, as it's the same file, > > or > > > am I missing a reason for this? > > > > > > # Copy attachments > > > if( $p_copy_attachments ) { > > > while( $t_bug_file = db_fetch_array( $t_result ) ) { > > > > > > * # prepare the new diskfile name and then copy the file* > > > * $t_file_path = dirname( $t_bug_file['folder'] );* > > > * $t_new_diskfile_name = $t_file_path . file_generate_unique_name( > > 'bug-' . > > > $t_bug_file['filename'], $t_file_path );* > > > * $t_new_file_name = file_get_display_name( $t_bug_file['filename'] );* > > > * if(( config_get( 'file_upload_method' ) == DISK ) ) {* > > > * copy( $t_bug_file['diskfile'], $t_new_diskfile_name );* > > > * chmod( $t_new_diskfile_name, config_get( > > 'attachments_file_permissions' ) > > > );* > > > * }* > > > > > > $t_query = "INSERT INTO {bug_file} > > > ( bug_id, title, description, diskfile, filename, folder, filesize, > > > file_type, date_added, content ) > > > VALUES ( %d, %s, %s, %s, %s, %s, %d, %s, %d, %d)"; > > > db_query( $t_query, array( $t_new_bug_id, $t_bug_file['title'], > > > $t_bug_file['description'], $t_new_diskfile_name, $t_new_file_name, > > > $t_bug_file['folder'], $t_bug_file['filesize'], $t_bug_file['file_type'], > > > $t_bug_file['date_added'], $t_bug_file['content'] ) ); > > > } > > > } > > > > > ------------------------------------------------------------------------------ > > > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > > > Discover the easy way to master current and previous Microsoft > > technologies > > > and advance your career. Get an incredible 1,500+ hours of step-by-step > > > tutorial videos with LearnDevNow. Subscribe today and save! > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk_______________________________________________ > > > mantisbt-dev mailing list > > > man...@li... > > > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > |
From: Victor B. <vb...@gm...> - 2013-09-25 05:41:59
|
I don't think we should worry about de-duping attachments. I'm not sure the savings here are worth the added complexities in the copy-issue, delete-attachment, delete-issue, and possibly the add-attachment. On Sun, Sep 8, 2013 at 5:56 AM, Roland Becker <ro...@at...> wrote: > If you think about eliminating duplicate files on disk you should also > think > about eliminating blobs in database. > Having different approaches is a bit confusing. > > Quite old known bug in bug_copy > http://www.mantisbt.org/bugs/view.php?id=9489 > > > Paul Richards <pa...@ma...> hat am 8. September 2013 um 14:37 > > geschrieben: > > > > > > Fair point on 1 - I wonder if we would be better checking for references > > then duplicating content though. > > > > Regarding number 2, bug_copy is already broken as we don't > > call file_normalize_attachment_path. > > > > > > > > > > On Sun, Sep 8, 2013 at 1:29 PM, Roland Becker <ro...@at...> wrote: > > > > > > > > If you don't have duplicate files you have to check for references to > the > > > file > > > when deleting issues and when deleting attachments. > > > > > > You have to create a duplicate if you copy from project 1 to project 2 > if > > > project 2 has a different configurations for the upload folder. > > > > > > > Paul Richards <pa...@ma...> hat am 8. September 2013 um > 14:10 > > > > geschrieben: > > > > > > > > > > > > I'm looking at bug copy, and thinking the bit in bold below could be > > > > removed: > > > > > > > > At the moment, when we 'copy' a bug, we also copy the attachments on > > > disk, > > > > creating duplicates - this seems somewhat silly, as it's the same > file, > > > or > > > > am I missing a reason for this? > > > > > > > > # Copy attachments > > > > if( $p_copy_attachments ) { > > > > while( $t_bug_file = db_fetch_array( $t_result ) ) { > > > > > > > > * # prepare the new diskfile name and then copy the file* > > > > * $t_file_path = dirname( $t_bug_file['folder'] );* > > > > * $t_new_diskfile_name = $t_file_path . file_generate_unique_name( > > > 'bug-' . > > > > $t_bug_file['filename'], $t_file_path );* > > > > * $t_new_file_name = file_get_display_name( $t_bug_file['filename'] > );* > > > > * if(( config_get( 'file_upload_method' ) == DISK ) ) {* > > > > * copy( $t_bug_file['diskfile'], $t_new_diskfile_name );* > > > > * chmod( $t_new_diskfile_name, config_get( > > > 'attachments_file_permissions' ) > > > > );* > > > > * }* > > > > > > > > $t_query = "INSERT INTO {bug_file} > > > > ( bug_id, title, description, diskfile, filename, folder, filesize, > > > > file_type, date_added, content ) > > > > VALUES ( %d, %s, %s, %s, %s, %s, %d, %s, %d, %d)"; > > > > db_query( $t_query, array( $t_new_bug_id, $t_bug_file['title'], > > > > $t_bug_file['description'], $t_new_diskfile_name, $t_new_file_name, > > > > $t_bug_file['folder'], $t_bug_file['filesize'], > $t_bug_file['file_type'], > > > > $t_bug_file['date_added'], $t_bug_file['content'] ) ); > > > > } > > > > } > > > > > > > > ------------------------------------------------------------------------------ > > > > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, > more! > > > > Discover the easy way to master current and previous Microsoft > > > technologies > > > > and advance your career. Get an incredible 1,500+ hours of > step-by-step > > > > tutorial videos with LearnDevNow. Subscribe today and save! > > > > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk_______________________________________________ > > > > mantisbt-dev mailing list > > > > man...@li... > > > > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > |