|
From: Damien R. <dam...@me...> - 2012-04-06 23:11:42
|
The current message for this error is: Invalid form security token. Did you submit the form twice by accident? In light of the number of issues related to this error, and my personal experience showing that in most cases it does NOT occur due to multiple form submissions but because of a timeout of the PHP session, I think we should reword this error message to mention that fact. Proposed alternatives (see #14122): Invalid form security token. This may happen if you submitted the form twice by accident, or because your session has timed out. Invalid form security token. This could be caused by accidentally submitting the form twice, or by a session timeout. Thoughts, comments ? Damien |
|
From: John R. <jo...@no...> - 2012-04-07 18:58:39
|
On Fri, Apr 6, 2012 at 4:11 PM, Damien Regad <dam...@me...> wrote: > The current message for this error is: > > Invalid form security token. Did you submit the form twice by accident? > > In light of the number of issues related to this error, and my personal > experience showing that in most cases it does NOT occur due to multiple > form submissions but because of a timeout of the PHP session, I think we > should reword this error message to mention that fact. > > Proposed alternatives (see #14122): > > Invalid form security token. This may happen if you submitted the form > twice by accident, or because your session has timed out. > > Invalid form security token. This could be caused by accidentally > submitting the form twice, or by a session timeout. > > Thoughts, comments ? I agree that the current message is inadequate. I also think both alternatives are good. Perhaps we should go one step further and have the message link to a bug report or wiki page with further information, explanations, and or advice on how to solve those problems? -- John Reese noswap.com |
|
From: Robert M. <rob...@gm...> - 2012-04-08 21:24:01
|
On Sat, Apr 7, 2012 at 9:58 PM, John Reese <jo...@no...> wrote: > On Fri, Apr 6, 2012 at 4:11 PM, Damien Regad > <dam...@me...> wrote: >> The current message for this error is: >> >> Invalid form security token. Did you submit the form twice by accident? >> >> In light of the number of issues related to this error, and my personal >> experience showing that in most cases it does NOT occur due to multiple >> form submissions but because of a timeout of the PHP session, I think we >> should reword this error message to mention that fact. >> >> Proposed alternatives (see #14122): >> >> Invalid form security token. This may happen if you submitted the form >> twice by accident, or because your session has timed out. >> >> Invalid form security token. This could be caused by accidentally >> submitting the form twice, or by a session timeout. >> >> Thoughts, comments ? > > I agree that the current message is inadequate. I also think both > alternatives are good. Perhaps we should go one step further and have > the message link to a bug report or wiki page with further > information, explanations, and or advice on how to solve those > problems? +1 on the rewording, either one. +0 on linking to a wiki page on mantisbt.org, given that we actually take the time to document it. -1 on linking on a bug report, these things are not very readable for users. > > > -- > John Reese > noswap.com > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev -- Sent from my (old) computer |
|
From: Roland B. <ro...@at...> - 2012-04-07 20:57:34
|
John Reese <jo...@no...> hat am 7. April 2012 um 20:58 geschrieben: > On Fri, Apr 6, 2012 at 4:11 PM, Damien Regad > <dam...@me...> wrote: > > The current message for this error is: > > > > Invalid form security token. Did you submit the form twice by accident? > > > > In light of the number of issues related to this error, and my personal > > experience showing that in most cases it does NOT occur due to multiple > > form submissions but because of a timeout of the PHP session, I think we > > should reword this error message to mention that fact. > > > > Proposed alternatives (see #14122): > > > > Invalid form security token. This may happen if you submitted the form > > twice by accident, or because your session has timed out. > > > > Invalid form security token. This could be caused by accidentally > > submitting the form twice, or by a session timeout. > > > > Thoughts, comments ? > > I agree that the current message is inadequate. I also think both > alternatives are good. Perhaps we should go one step further and have > the message link to a bug report or wiki page with further > information, explanations, and or advice on how to solve those > problems? > If the message is most of the time caused by session timeout the message should be the other way round: Invalid form security token. This could be caused by a session timeout, or accidentally submitting the form twice. I like the idea to provide some more information. I don't like a) to show this quite technical information to end-users which are not administrators b) to link to an external page (maybe we should link to administrator documentation) |
|
From: Damien R. <dam...@me...> - 2012-04-08 22:38:42
|
Thanks for the feedback. On 07.04.2012 22:57, Roland Becker wrote: > If the message is most of the time caused by session timeout the message > should be the other way round: > Invalid form security token. This could be caused by a session timeout, > or accidentally submitting the form twice. Good point, I agree with you. > I like the idea to provide some more information. > I don't like > a) to show this quite technical information to end-users which are not > administrators > b) to link to an external page (maybe we should link to administrator > documentation) I was actually thinking about adding a section on error messages in the wiki (maybe as part of the faq page ? or another dedicated one ?). Are you saying that this should be an integral part of the admin guide ? I also don't believe this should be referenced in error message itself, as you say it's too technical and concerns only the admin. Damien |
|
From: Roland B. <ro...@at...> - 2012-04-09 12:18:59
|
> > I like the idea to provide some more information. > > I don't like > > a) to show this quite technical information to end-users which are not > > administrators > > b) to link to an external page (maybe we should link to administrator > > documentation) > > I was actually thinking about adding a section on error messages in the > wiki (maybe as part of the faq page ? or another dedicated one ?). Are > you saying that this should be an integral part of the admin guide ? Yes, that's what I meant. I see two advantages when having such kind of information in admin guide instead of wiki: The admin guide is delivered with the installation, so we could use context sensitive help without linking to foreign pages, something like: http://<yourLocalMantisBT>/docbook/adminguide/en/administration_guide.html#ADMIN.TROUBLESHOOTING The admin guide is versioned information, the wiki is not. There are no wiki branches, where users could look at the information which fits to their installed version. |
|
From: John R. <jo...@no...> - 2012-04-09 17:37:22
|
On Mon, Apr 9, 2012 at 5:18 AM, Roland Becker <ro...@at...> wrote: > Yes, that's what I meant. > I see two advantages when having such kind of information in > admin guide instead of wiki: > > The admin guide is delivered with the installation, so we could use > context sensitive help without linking to foreign pages, > something like: > http://<yourLocalMantisBT>/docbook/adminguide/en/administration_guide.html#ADMIN.TROUBLESHOOTING > > The admin guide is versioned information, the wiki is not. > There are no wiki branches, where users could look at the information > which fits to their installed version. That's actually an extremely good point, and I really like it. But it also assumes that users are running an upstream release of MantisBT -- anyone using a distro package or a git checkout won't be able to follow those links. That's the only benefit I see to referencing a page on our site. Not sure that outweighs the benefits of your suggestion though... -- John Reese noswap.com |
|
From: Roland B. <ro...@at...> - 2012-04-09 18:27:57
|
John Reese <jo...@no...> hat am 9. April 2012 um 19:37 geschrieben: > On Mon, Apr 9, 2012 at 5:18 AM, Roland Becker <ro...@at...> wrote: > > Yes, that's what I meant. > > I see two advantages when having such kind of information in > > admin guide instead of wiki: > > > > The admin guide is delivered with the installation, so we could use > > context sensitive help without linking to foreign pages, > > something like: > > http://<yourLocalMantisBT>/docbook/adminguide/en/administration_guide.html#ADMIN.TROUBLESHOOTING > > > > The admin guide is versioned information, the wiki is not. > > There are no wiki branches, where users could look at the information > > which fits to their installed version. > > That's actually an extremely good point, and I really like it. But it > also assumes that users are running an upstream release of MantisBT -- > anyone using a distro package or a git checkout won't be able to > follow those links. That's the only benefit I see to referencing a > page on our site. Not sure that outweighs the benefits of your > suggestion though... > If this is needed we could add a configuration option Default in config_defaults_inc.php $g_documentation_root = "%path%docbook/adminguide" Distros and git checkouts can change this in config_inc.php to $g_documentation_root = 'http://www.mantisbt.org/docs/master-1.2.x' BTW, I never used a MantisBT distro package. They don't deliver the docs? |
|
From: Damien R. <dam...@me...> - 2012-04-14 20:34:37
|
I have just pushed some commits to: - amend Error 2800's message as per my initial suggestion, also taking Roland's remark into consideration by mentioning the timeout first. - added a new chapter "Troubleshooting" in the Admin guide, reflecting my findings on this error. - documented several missing config options Would appreciate your review and comments/corrections on the new chapter. All of the above have been ported to master as well. With regards to automatically linking to the documentation from the error message, I logged a new issue [1] on the tracker to follow up. Damien [1] http://www.mantisbt.org/bugs/view.php?id=14154 |
|
From: Damien R. <dam...@me...> - 2012-04-14 21:00:48
|
On 09.04.2012 14:18, Roland Becker wrote: > The admin guide is versioned information, the wiki is not. By the way, just for the record, this statement is incorrect. e.g. http://www.mantisbt.org/wiki/doku.php/mantisbt:start?do=revisions D |
|
From: Roland B. <ro...@at...> - 2012-04-15 11:05:19
|
Damien Regad <dam...@me...> hat am 14. April 2012 um 23:00 geschrieben: > On 09.04.2012 14:18, Roland Becker wrote: > > The admin guide is versioned information, the wiki is not. > > By the way, just for the record, this statement is incorrect. > e.g. http://www.mantisbt.org/wiki/doku.php/mantisbt:start?do=revisions > > D > You are right,I expressed in a wrong way what I meant when writing "versioned" We don't have a Wiki for MantisBT versions 1.1.x, 1.2.x, 1.3.x but we do have administrator guides for the versions. Maybe "Wiki does not support branching" are better words for what I really mean. Still fighting with my sometimes misleading English ;-) |