From: Victor B. <vi...@fu...> - 2004-02-02 21:02:48
|
Hi All, I would like to start on the use of templates in Mantis. This should involve changes like the following: - Add Smarty 2.61 as smarty261 (or maybe smarty) in Mantis source tree. - Add configuration option to point to it. - Add templates/ and templates_c/ - Add a check in admin/check.php to make sure template_c/ is a writable-dir. - Implement bug_view_page2.php (to be renamed once it is finished and stable) which collects all advanced information but uses bug_view_simple.tpl, bug_view_advanced.tpl, bug_print_simple.tpl, or bug_print_advanced.tpl. The same should happen for bug_update. - Implement a template for the bugs table in view_bugs page. - Implement a template for the bugs table in print_all_bugs page. - Implement a template for resolve / close pages - ... Eventually, we should have Mantis use templates for all its output. However, this can be a goal for 0.19.0. At the moment, I would like to get templates implemented for pages with the greatest benefits. Benefits of using templates: - Allow users to simply add/remove fields as they require. For example, adding the version field to the simple page, or adding a custom field to resolved page, ...etc. The preparation / action pages will be preparing / processing all fields. - Allow users to easily change look and feel. - Factoring of code. I would appreciate your feedback. Also if someone is interested in getting this happening soon and would like to help with development this will be great. Regards, Victor. |
From: Kick <ch...@ep...> - 2004-02-02 21:21:17
|
Victor, Sounds good to me. I've been playing around with Smarty for a couple of my own projects, and I have to say that I'm very, very impressed.=20 Re-doing the login page and preference pages should be snap. Headers and footers also become easier. Is this to be started now? Chris On 1/1/1970, "Victor Boctor" <vi...@fu...> wrote: >Hi All, > >I would like to start on the use of templates in Mantis. This should >involve changes like the following: > >- Add Smarty 2.61 as smarty261 (or maybe smarty) in Mantis source tree. >- Add configuration option to point to it. >- Add templates/ and templates_c/ >- Add a check in admin/check.php to make sure template_c/ is a >writable-dir. >- Implement bug_view_page2.php (to be renamed once it is finished and >stable) which collects all advanced information but uses >bug_view_simple.tpl, bug_view_advanced.tpl, bug_print_simple.tpl, or >bug_print_advanced.tpl. The same should happen for bug_update. >- Implement a template for the bugs table in view_bugs page. >- Implement a template for the bugs table in print_all_bugs page. >- Implement a template for resolve / close pages >- ... > >Eventually, we should have Mantis use templates for all its output. >However, this can be a goal for 0.19.0. At the moment, I would like to >get templates implemented for pages with the greatest benefits. > >Benefits of using templates: >- Allow users to simply add/remove fields as they require. For example, >adding the version field to the simple page, or adding a custom field to >resolved page, ...etc. The preparation / action pages will be preparing >/ processing all fields. >- Allow users to easily change look and feel. >- Factoring of code. > >I would appreciate your feedback. Also if someone is interested in >getting this happening soon and would like to help with development this >will be great. > >Regards, >Victor. > > > > >------------------------------------------------------- >The SF.Net email is sponsored by EclipseCon 2004 >Premiere Conference on Open Tools Development and Integration >See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. >http://www.eclipsecon.org/osdn >_______________________________________________ >Mantisbt-dev mailing list >Man...@li... >https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > > |
From: Jeroen L. <jl...@ca...> - 2004-02-02 23:19:26
|
On Tue, 3 Feb 2004 08:00:24 +1100, Victor Boctor <vi...@fu...> wrote: > Benefits of using templates: > - Allow users to simply add/remove fields as they require. For example, > adding the version field to the simple page, or adding a custom field to > resolved page, ...etc. The preparation / action pages will be preparing > / processing all fields. > - Allow users to easily change look and feel. > - Factoring of code. I thought we were moving towards having all the logic in core/* files, and making the other files pretty much templates in PHP? Or is there a problem with that? Jeroen |
From: <lu...@ne...> - 2004-02-03 06:26:09
|
Jeroen Latour wrote: > I thought we were moving towards having all the logic in core/* files, > and making the other files pretty much templates in PHP? Or is there a > problem with that? Hi Folks, I was the person who started that (smarty) template thread in 2002 (Yes, it's that long ago). I dunno, if anyone still remembers me, since I've been quietly lurking around for more than a year now. To apologize: I lost my job and had to find a new one. It were "stormy times" in my life, I didn't have time to do anything for mantis until I recently installed it in my new company, but I never lost it out of sight. I also work in another open source project, but that's a different story. That said. I can honestly claim that I didn't take a look at the code for *quite* some time. The reason for starting the template discussion was to achieve a clean separation from logic and display (code/content, whatever you prefer). Mantis was far away from that in 2002, but has made a giant step towards that goal in the meantime. The only reason left for using a template engine after having done (insert quote from Jeroen here) would be that it would be easier for *some* people to tweak the appearance of Mantis to their needs. The conclusion for me is that I withdraw my request for using a template engine, even though smarty is the coolest one hanging around. I'd rather recommend to focus on things like XHTML compliance, getting rid of the table driven layout where it restricts flexibility and to implement a (or several) better style sheet(s) for mantis. This way a lot of the customization on the client side can be handled easily by tweaking (or switching) the css. There would, for example, be no need to have the print_* pages anymore, because the style can handle it for you. Cheers -Lübbe |
From: Martin W. <mar...@xm...> - 2004-02-03 10:14:19
|
Lübbe Onken wrote: > I was the person who started that (smarty) template thread in 2002 (Yes, > it's that long ago). I dunno, if anyone still remembers. I remember! :-) > That said. I can honestly claim that I didn't take a look at the code > for *quite* some time. The reason for starting the template discussion > was to achieve a clean separation from logic and display (code/content, > whatever you prefer). Mantis was far away from that in 2002, but has > made a giant step towards that goal in the meantime. The only reason > left for using a template engine after having done (insert quote from > Jeroen here) would be that it would be easier for *some* people to tweak > the appearance of Mantis to their needs. The conclusion for me is that I > withdraw my request for using a template engine, even though smarty is > the coolest one hanging around. I agree 100%. I was reluctant then (2002), but even more now when mantis has been restructured. > I'd rather recommend to focus on things like XHTML compliance, getting > rid of the table driven layout where it restricts flexibility and to > implement a (or several) better style sheet(s) for mantis. This way a > lot of the customization on the client side can be handled easily by > tweaking (or switching) the css. There would, for example, be no need to > have the print_* pages anymore, because the style can handle it for you. Amen. Smarty may be cool, but it seems like a wrong step to redesign mantis just for the fun of it. Fix bugs and add needed features instead. /M |
From: Robert F. <rf...@mo...> - 2004-02-03 22:47:24
|
On Tue, 2004-02-03 at 21:14, Martin Wickman wrote: > Lübbe Onken wrote: > > > I was the person who started that (smarty) template thread in 2002 (Yes, > > it's that long ago). I dunno, if anyone still remembers. > > I remember! :-) Me too :) > > I agree 100%. I was reluctant then (2002), but even more now when mantis > has been restructured. > > > I'd rather recommend to focus on things like XHTML compliance, getting > > rid of the table driven layout where it restricts flexibility and to > > implement a (or several) better style sheet(s) for mantis. This way a > > lot of the customization on the client side can be handled easily by > > tweaking (or switching) the css. There would, for example, be no need to > > have the print_* pages anymore, because the style can handle it for you. > > Amen. Smarty may be cool, but it seems like a wrong step to redesign > mantis just for the fun of it. Fix bugs and add needed features instead. > I second that, I'd rather see the use of CSS and supporting elements to handle the layout and design. Much more flexible and seems to be the way of the future. Rob. |
From: <lu...@ne...> - 2004-02-03 23:28:17
|
Martin Wickman wrote: > Fix bugs and add needed features instead. Amen :-) -Lübbe |
From: Kick <ch...@ep...> - 2004-02-04 17:36:33
|
On 1/1/1970, "L=FCbbe Onken" <lu...@ne...> wrote: >Martin Wickman wrote: > >> Fix bugs and add needed features instead. > >Amen :-) > >-L=FCbbe Personally, I feel moving to a template system would increase the speed in which bugs are fixed (after the initial shock of moving, of course :D ) Chris |