From: <gi...@ma...> - 2009-10-28 06:58:53
|
The branch, master has been updated via c8a9d4a5a04b582b4f30aa0ae1dead245a9b56a5 (commit) from 834c8ed77b499c20490e50985793b6cf345c8c07 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c8a9d4a5a04b582b4f30aa0ae1dead245a9b56a5 Author: Victor Boctor <vb...@gm...> Date: Tue Oct 27 23:58:22 2009 -0700 Fixes #10841: Target Version not cleared when Version is deleted. ----------------------------------------------------------------------- Summary of changes: core/version_api.php | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 deletions(-) ----------------------------------------------------------------------- commit c8a9d4a5a04b582b4f30aa0ae1dead245a9b56a5 Author: Victor Boctor <vb...@gm...> Date: Tue Oct 27 23:58:22 2009 -0700 Fixes #10841: Target Version not cleared when Version is deleted. diff --git a/core/version_api.php b/core/version_api.php index 5df12d2..edc2678 100644 --- a/core/version_api.php +++ b/core/version_api.php @@ -288,6 +288,11 @@ function version_remove( $p_version_id, $p_new_version = '' ) { WHERE ( project_id=' . db_param() . ' ) AND ( fixed_in_version=' . db_param() . ')'; db_query_bound( $query, Array( $p_new_version, $c_project_id, $t_old_version ) ); + $query = "UPDATE $t_bug_table + SET target_version=" . db_param() . ' + WHERE ( project_id=' . db_param() . ' ) AND ( target_version=' . db_param() . ')'; + db_query_bound( $query, array( $p_new_version, $c_project_id, $t_old_version ) ); + # db_query errors on failure so: return true; } @@ -303,20 +308,16 @@ function version_remove_all( $p_project_id ) { $t_project_version_table = db_get_table( 'project_version' ); $t_bug_table = db_get_table( 'bug' ); - $query = "DELETE FROM $t_project_version_table - WHERE project_id=" . db_param(); - - db_query_bound( $query, Array( $c_project_id ) ); - + # remove all references to versions from verison, fixed in version and target version. $query = "UPDATE $t_bug_table - SET version='' + SET version='', fixed_in_version='', target_version='' WHERE project_id=" . db_param(); - db_query_bound( $query, Array( $c_project_id ) ); + db_query_bound( $query, array( $c_project_id ) ); - $query = "UPDATE $t_bug_table - SET fixed_in_version='' + # remove the actual versions associated with the project. + $query = "DELETE FROM $t_project_version_table WHERE project_id=" . db_param(); - db_query_bound( $query, Array( $c_project_id ) ); + db_query_bound( $query, array( $c_project_id ) ); # db_query errors on failure so: return true; ----------------------------------------------------------------------- -- Mantis Bug Tracker |