[Lxr-dev] [ lxr-Bugs-3510739 ] Include path remapping randomly fails

[SourceForge.net <no...@so...>]

Bugs item #3510739, was opened at 2012-03-24 01:00
Message generated for change (Comment added) made by ajlittoz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3510739&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: current cvs
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Andre-Littoz (ajlittoz)
Assigned to: Andre-Littoz (ajlittoz)
Summary: Include path remapping randomly fails

Initial Comment:
Navigating through the kernel source with architecture and sub-architectures requires that 'maps' rules are applied in a definite order since they are cumulative.

Remapping rules are stored in Perl hash. Application is requested by a "for each (%maps)" instruction which pulls the rule in random order ("to protect against attacks", Perldoc says). The consequence is the order of the rules is not preserved, thus some dependent rules may be applied before the master rule and they will fail.

However, it may work correctly sometimes which hides the bug. Anyway, this is not satisfactory.

Suggestion: change rules storage from hash to array to control the application order.

Is there an impact on performance?

----------------------------------------------------------------------

>Comment By: Andre-Littoz (ajlittoz)
Date: 2012-03-27 09:51

Message:
'maps' parameter changed from hash to array.

This change involved a minor modification in sub mappath. A new sub
unmappath has been created to "reverse" (when this is possible) the effects
of mappath.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3510739&group_id=27350