Re: [Lxr-dev] Further Details on What I'm Looking to Fix in LXR
Brought to you by:
ajlittoz
From: Malcolm B. <mal...@gm...> - 2009-03-30 11:56:08
|
Hi Adrian, I've CC'ed lxr-developer as well to keep everyone informed as to what's happening. On Sun, Mar 29, 2009 at 6:16 PM, <ad...@is...> wrote: > Hi Malcolm, > > Just thought I'd let you know what bugs I'm planning to fix before I get > onto the meaty stuff mentioned in the email I sent just now. Since there > aren't any bugs for these things on SourceForge would you like me to raise > some so the changes are tracked fully or shall I just submit changes to CVS > as I go along? Yes, please raise bugs and then record the bug as fixed in the CVS change comment. >> Here are the bugs in the order I'm thinking of working on them: > > 1) Allow the scripts to be run on windows as follows: > < #!/usr/bin/perl –T >> #!perl –T Is this really necessary? On Windows, you have to type "perl genxref" etc anyway, so the #! doesn't have bad effects. As far as I'm aware the #! is ignored. Or is the problem with the source/find/ident scripts running from CGI or mod_perl context? > > 2) LXR::Config > Add some minor validation and ensure that various directories exist Great. > 3) search > Fix issue where swish results not being shown correctly due to pipe issues > on windows OK - can you test this on a Linux box as well to make sure it doesn't break Unix? I'm using VirtualBox (www.virtualbox.com) and Ubuntu to have a virtual Linux server on my windows laptop - I can send you details on how to set up if it would help. Otherwise I can test the patches my side. > 4) LXR::Lang / LXR\Lang\Generic.pm > processinclude() should check to see if the include code contains a reserved > word (e.g. #include) > > 5) LXR\Lang\generic.conf > Add pre-processor keywords to the C and C++ language definitions Both look good to me. Cheers, Malcolm |