[Lxr-dev] [ lxr-Bugs-565811 ] unreadable files can terminate genxref !! includes FIX

[<no...@so...>]

Bugs item #565811, was opened at 2002-06-07 22:25
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=565811&group_id=27350

Category: Lang support
Group: v0.9.1
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Gregor Hartmann (grex)
Assigned to: Nobody/Anonymous (nobody)
Summary: unreadable files can terminate genxref !! includes FIX

Initial Comment:
When an unreadable file is encountered whos language cannot be determined by the filename the file is 
opened to see if it is a script.

The file is opened using FileHandle to read the first line.
however if new FileHandle fails, this is not checked and getline terminates the program with following 
error:
Can't call method "getline" on an undefined value at lib/LXR/Lang.pm line 47.

I changed some lines in lib/LXR/Lang.pl to fix this. The files are then treated as if no language was found.

I Added two lines of context above and below starting at line 41 in lib/LXR/Lang.pl

        if (!defined $lang) {
        # Try to see if it's a script
                my $shebang;
                my $fh = $files->getfilehandle($pathname, $release);
                if ( 1 )
                {
                        $fh->getline =~ /^\#!\s*(\S+)/s;
                        $shebang = $1;
                }
                else
                {
                        $shebang = "";
                }

                my %filetype = %{$config->filetype};
                my %inter = %{$config->interpreters};

----------------------------------------------------------------------

>Comment By: Malcolm Box (mbox)
Date: 2002-07-29 09:47

Message:
Logged In: YES 
user_id=215386

Fixed in current CVS

----------------------------------------------------------------------

Comment By: Gregor Hartmann (grex)
Date: 2002-06-07 23:46

Message:
Logged In: YES 
user_id=559509

that should be a 
if ( $fh )
instead of 
if ( 1 )
of course up there

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=565811&group_id=27350