Re: [Lxr-dev] DB connection bug

[Malcolm B. <ma...@br...>]

"Peder O. Klingenberg" wrote:
> 
> Malcolm Box <ma...@br...> writes:
> 
> > I have a possible fix that I'm testing out at the moment with Mysql.pm
> > (I don't have Postgres installed yet).  This is to make the $dbh handle
> > local to each Mysql object ie $self->{dbh} rather than a package
> > variable.  I've also made all the sql statements object variables rather
> > than package ones.
> >
> > This then lets the connection be closed via a DESTROY subroutine
> > whenever the index object goes out of scope.
> 
> Wow, what syncronicity.
> 
> I've done the same thing with Postgres.  While this solves the problem
> seen with genxref, I now get complaints about not being able to call
> commit during global gc or destruction or something (I don't recall
> the exact message) during execution of the source script.  I haven't
> quite figured that out yet.

I'm not seeing any errors, but then again I'm not calling commit :-)  If
I try calling commit, I get a message saying that it's ineffective when
autocommit is in operation.  All this is with MySQL.

Since this approach gets rid of the warnings and seems to work well, I'm
going to go ahead and submit it.

Now there's just the matter of the memory leak that seems to be there -
genxref balloons to more than 30Mb when indexing my test tree, and I
don't see any reason for that sort of memory consumption.

Cheers,

Malcolm