linux-apus-devel

Re: [PATCH] drivers/scsi/53c7xx.c error handling and cleanup (241p9)

[Rasmus A. <ra...@ja...>]

On Tue, Jan 23, 2001 at 12:27:36AM +0100, Rasmus Andersen wrote:

Hi again.

I completely messed up a large part of the patches posted yesterday due
to lack of sleep and being clinically braindead (the compile test was
run in the wrong tree...).

So I'll be posting some new patches that actually compiles (knock on
wood). I apologise for the unnecessary mails :(

(Thanks goes to Bill Wendling for bringing my attention to this one.)

--- linux-ac10-clean/drivers/scsi/53c7xx.c	Sun Nov 12 04:01:11 2000
+++ linux-ac10/drivers/scsi/53c7xx.c	Tue Jan 23 21:25:18 2001
@@ -1077,19 +1077,18 @@
     {
 	printk("scsi%d : IRQ%d not free, detaching\n",
 		host->host_no, host->irq);
-	scsi_unregister (host);
-	return -1;
+	goto err_unregister;
     } 
 
     if ((hostdata->run_tests && hostdata->run_tests(host) == -1) ||
         (hostdata->options & OPTION_DEBUG_TESTS_ONLY)) {
     	/* XXX Should disable interrupts, etc. here */
-	scsi_unregister (host);
-    	return -1;
+	goto err_free_irq;
     } else {
 	if (host->io_port)  {
 	    host->n_io_port = 128;
-	    request_region (host->io_port, host->n_io_port, "ncr53c7xx");
+	    if (!request_region (host->io_port, host->n_io_port, "ncr53c7xx"))
+		goto err_free_irq;
 	}
     }
     
@@ -1098,6 +1097,12 @@
 	hard_reset (host);
     }
     return 0;
+
+ err_free_irq:
+    free_irq(host->irq,  NCR53c7x0_intr);
+ err_unregister:
+    scsi_unregister(host);
+    return -1;
 }
 
 /* 
@@ -1206,8 +1211,11 @@
     size += 256;
 #endif
     /* Size should be < 8K, so we can fit it in two pages. */
-    if (size > 8192)
-      panic("53c7xx: hostdata > 8K");
+    if (size > 8192) {
+      printk(KERN_ERR "53c7xx: hostdata > 8K\n");
+      return -1;
+    }
+
     instance = scsi_register (tpnt, 4);
     if (!instance)
     {
@@ -3091,8 +3099,10 @@
 #endif
 /* FIXME: for ISA bus '7xx chips, we need to or GFP_DMA in here */
 
-        if (size > 4096)
-            panic ("53c7xx: allocate_cmd size > 4K");
+        if (size > 4096) {
+            printk (KERN_ERR "53c7xx: allocate_cmd size > 4K\n");
+	    return NULL;
+	}
         real = get_free_page(GFP_ATOMIC);
         if (real == 0)
         	return NULL;

-- 
        Rasmus(ra...@ja...)

Are they taking DDT?
                -- Vice President Dan Quayle asking doctors at a Manhattan
                   AIDS clinic about their treatments of choice, 4/30/92
                   (reported in Esquire, 8/92, and NY Post early May 92)

sound in 2.2.10

[Piotr T. <du...@ds...>]

i compiled 2.2.10 kernel with sound, but it has bad sample rate (sound is
slow). In mpg123 i can set sample rate to 1:2, but in some programs, like
smpeg, i can't do it. Anybody know what i have to change in sound drivers
or kernel source ?.

dus

[PATCH] make drivers/scsi/fastlane.c check return code of request_irq (241p9)

[Rasmus A. <ra...@ja...>]

Hi.

(I have not been able to find a maintainer for this code.)

The following patch makes drivers/scsi/fastlane.c check the return
code of request_irq and converts (some) error paths to use forward
gotos.

It applies cleanly against ac10 and 241p9.

Comments?


--- linux-ac10-clean/drivers/scsi/fastlane.c	Mon Oct 16 21:51:16 2000
+++ linux-ac10/drivers/scsi/fastlane.c	Sun Jan 21 20:27:17 2001
@@ -96,9 +96,7 @@
 		 * this ID value. Fortunately only Fastlane maps in Z3 space
 		 */
 		if (board < 0x1000000) {
-			release_mem_region(board+FASTLANE_ESP_ADDR,
-					   sizeof(struct ESP_regs));
-			return 0;
+			goto err_release;
 		}
 		esp = esp_allocate(tpnt, (void *)board+FASTLANE_ESP_ADDR);
 
@@ -146,10 +144,7 @@
 
 		if(!address){
 			printk("Could not remap Fastlane controller memory!");
-			scsi_unregister (esp->ehost);
-			release_mem_region(board+FASTLANE_ESP_ADDR,
-					   sizeof(struct ESP_regs));
-			return 0;
+			goto err_unregister;
 		}
 
 
@@ -171,8 +166,11 @@
 
 		esp->irq = IRQ_AMIGA_PORTS;
 		esp->slot = board+FASTLANE_ESP_ADDR;
-		request_irq(IRQ_AMIGA_PORTS, esp_intr, SA_SHIRQ,
-			    "Fastlane SCSI", esp_intr);
+		if (request_irq(IRQ_AMIGA_PORTS, esp_intr, SA_SHIRQ,
+				"Fastlane SCSI", esp_intr)) {
+			printk(KERN_WARNING "Fastlane: Could not get IRQ%d, aborting.\n", esp_intr);
+			goto err_unmap;
+		}			
 
 		/* Controller ID */
 		esp->scsi_id = 7;
@@ -188,6 +186,15 @@
 		return esps_in_use;
 	    }
 	}
+	return 0;
+
+ err_unmap:
+	iounmap(board, z->resource.end-board+1);
+ err_unregister:
+	scsi_unregister (esp->ehost);
+ err_release:
+	release_mem_region(board+FASTLANE_ESP_ADDR,
+			   sizeof(struct ESP_regs));
 	return 0;
 }
 

-- 
Regards,
        Rasmus(ra...@ja...)

"No man is genuinely happy, married, who has to drink worse whiskey than he
used to drink when he was single." H.L. Mencken

[PATCH] drivers/scsi/53c7xx.c error handling and cleanup (241p9)

[Rasmus A. <ra...@ja...>]

Hi.

(I hope I haven't missed any relevant lists :) )

The following patch makes drivers/scsi/53c7xx.c check the return code
of request_region and release the irq properly in the error path.

It applies cleanly against ac10 and 241p9.

Comments?


--- linux-ac10-clean/drivers/scsi/53c7xx.c	Sun Nov 12 04:01:11 2000
+++ linux-ac10/drivers/scsi/53c7xx.c	Sun Jan 21 21:56:29 2001
@@ -1077,19 +1077,18 @@
     {
 	printk("scsi%d : IRQ%d not free, detaching\n",
 		host->host_no, host->irq);
-	scsi_unregister (host);
-	return -1;
+	goto err_unregister;
     } 
 
     if ((hostdata->run_tests && hostdata->run_tests(host) == -1) ||
         (hostdata->options & OPTION_DEBUG_TESTS_ONLY)) {
     	/* XXX Should disable interrupts, etc. here */
-	scsi_unregister (host);
-    	return -1;
+	goto err_free_irq;
     } else {
 	if (host->io_port)  {
 	    host->n_io_port = 128;
-	    request_region (host->io_port, host->n_io_port, "ncr53c7xx");
+	    if (!request_region (host->io_port, host->n_io_port, "ncr53c7xx"))
+		goto err_free_irq;
 	}
     }
     
@@ -1098,6 +1097,12 @@
 	hard_reset (host);
     }
     return 0;
+
+ err_free_irq:
+    free_irq(host->irq,  NCR53c7x0_intr);
+ err_unregister:
+    scsi_unregister(host);
+    return -1;
 }
 
 /* 
@@ -1206,8 +1211,10 @@
     size += 256;
 #endif
     /* Size should be < 8K, so we can fit it in two pages. */
-    if (size > 8192)
-      panic("53c7xx: hostdata > 8K");
+    if (size > 8192) {
+      printk(KERN_ERR "53c7xx: hostdata > 8K\n");
+      return -1;
+
     instance = scsi_register (tpnt, 4);
     if (!instance)
     {
@@ -3091,8 +3098,10 @@
 #endif
 /* FIXME: for ISA bus '7xx chips, we need to or GFP_DMA in here */
 
-        if (size > 4096)
-            panic ("53c7xx: allocate_cmd size > 4K");
+        if (size > 4096) {
+            printk (KERN_ERR "53c7xx: allocate_cmd size > 4K\n");
+	    return NULL;
+	}
         real = get_free_page(GFP_ATOMIC);
         if (real == 0)
         	return NULL;

-- 
        Rasmus(ra...@ja...)

If a man says something in a forest and there are no women around to 
hear him, is he still wrong? -- Anonymous

dmesg output for

[T. <Ren...@gm...>]

Hi everybody!

Attached the dmesg output of the vmlinux-2.4.0-apus-fastlane-dbg.gz from
ftp://linux-apus.sourceforge.net/pub/linux-apus/test/ where the m68k
version runs successful with FASTLANE!

Bye
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: 2.4.0

[T. <Ren...@gm...>]

Hi Roman and all over there!

Roman Zippel wrote:

> Hi,
>
> I've put two kernels into
> ftp://linux-apus.sourceforge.net/pub/linux-apus/test/.
> vmlinux-2.4.0-m68k-fastlane.gz: is a m68k kernel to see whether it still
> works here.
> vmlinux-2.4.0-apus-fastlane-dbg.gz: with all debugging output enabled I
> could find. :)
>
> Ok, let's see what happens. :-)
>

OK (Almost) Daily activity report!

Here we go:
I send you the dmesg output of the APUS kernel with SCSI debugging attached!
The kernel results into a endless loop trying to detect all connected SCSI-HW,
I reset the Amiga!

BUT NOW!!!! I also tried the m68k version you load up! And guess: The kernel
detects the fastlane and both connected drives (IBM HD + TEAC CDROM) including
all their attributes without any problems!! I was amazed!

Hope this will help somebody to fix the APUS FASTLANE probs!

Kind regards
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: [rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Geert U. <ge...@li...>]

On Fri, 19 Jan 2001, Rasmus Andersen wrote:
> On Fri, Jan 19, 2001 at 08:56:47AM +0100, Geert Uytterhoeven wrote:
> > We should add entries to MAINTAINERS, like:
> > 
> >     Amiga -> linux-m68k, linux-apus-devel
> >     APUS -> linux-apus-devel
> >     Atari -> linux-m68k
> >     ...
> > 
> > BTW, I saw on linux-kernel you fixed some more m68k things.
> 
> I did? :) Like I said earlier I have no clue what files in scsi/*
> belong to which achitecture (apart from the obvious ones). I guess
> that if the MAINTAINERS entries suggested above were added it would
> help, but this implies that people should grep the source for things
> like AMIGA etc in order to find out if there is a match with a magic
> word in MAINTAINERS. I think the easiest thing to do (for me :))

I can imagine... But everything which uses `zorro_find()' is for Amiga :-)

> would be adding the list addresses to the to of the files. That way
> people like me would know that patches for blz1230.c should go to
> linux-apus-devel etc.

Yes indeed.

> PS: Have you forwarded my patches from linux-kernel to the appro-
> priate lists? Or should I look into that myself?

Not yet. I'll do, and CC you.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Rasmus A. <ra...@ja...>]

On Fri, Jan 19, 2001 at 08:56:47AM +0100, Geert Uytterhoeven wrote:
> 
> We should add entries to MAINTAINERS, like:
> 
>     Amiga -> linux-m68k, linux-apus-devel
>     APUS -> linux-apus-devel
>     Atari -> linux-m68k
>     ...
> 
> BTW, I saw on linux-kernel you fixed some more m68k things.

I did? :) Like I said earlier I have no clue what files in scsi/*
belong to which achitecture (apart from the obvious ones). I guess
that if the MAINTAINERS entries suggested above were added it would
help, but this implies that people should grep the source for things
like AMIGA etc in order to find out if there is a match with a magic
word in MAINTAINERS. I think the easiest thing to do (for me :))
would be adding the list addresses to the to of the files. That way
people like me would know that patches for blz1230.c should go to
linux-apus-devel etc.

But then again I'm not the one to maintain these addresses so you
people might have other ideas.


Regards,
  Rasmus

PS: Have you forwarded my patches from linux-kernel to the appro-
priate lists? Or should I look into that myself?

Re: [rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Geert U. <ge...@li...>]

On Fri, 19 Jan 2001, Sven LUTHER wrote:
> On Thu, Jan 18, 2001 at 11:08:46PM +0100, Rasmus Andersen wrote:
> > On Thu, Jan 18, 2001 at 01:33:21PM +0100, Sven LUTHER wrote:
> > > Best is to send this kind of mails to :
> > > 
> > > lin...@li...
> > > 
> > > Which is the mailing list where all apus developper are subscribed, andwhere
> > > patches are supposed to be sent.
> > > 
> > 
> > OK. But how do I get from drivers/scsi/blz1230.c to the address of that
> > mailing list? It is not even in MAINTAINERS. And for the other appropriate
> > drivers in scsi/ ?
> 
> huh, don't know, maybe we should add some info there.

We should add entries to MAINTAINERS, like:

    Amiga -> linux-m68k, linux-apus-devel
    APUS -> linux-apus-devel
    Atari -> linux-m68k
    ...

BTW, I saw on linux-kernel you fixed some more m68k things.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Sven L. <lu...@dp...>]

On Thu, Jan 18, 2001 at 11:08:46PM +0100, Rasmus Andersen wrote:
> On Thu, Jan 18, 2001 at 01:33:21PM +0100, Sven LUTHER wrote:
> > Best is to send this kind of mails to :
> > 
> > lin...@li...
> > 
> > Which is the mailing list where all apus developper are subscribed, andwhere
> > patches are supposed to be sent.
> > 
> 
> OK. But how do I get from drivers/scsi/blz1230.c to the address of that
> mailing list? It is not even in MAINTAINERS. And for the other appropriate
> drivers in scsi/ ?

huh, don't know, maybe we should add some info there.

that said, in the same place you got your kernel source from, should have
been this info, not usre though. Tell me where did you get the kernel source
or the apus specific patches ? and which date did they have ?

> > I guess this list is mentioned in the appropriate place (but then what do you
> > consider the appropriate places anyway, and where did you get Jesper's email
> > address ? On some obsolete CD ort something such ?), and if not, Maybe we
> > should add it there.
> 
> I got Jesper's mail address from the Copyright notice at the top of the
> file. I hoped he would be kind enough to redirect me if he was not invol-
> ved anymore. And he was :) (kind enough)

:)))

Friendly,

Sven Luther

Re: [rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Rasmus A. <ra...@ja...>]

On Thu, Jan 18, 2001 at 01:33:21PM +0100, Sven LUTHER wrote:
> Best is to send this kind of mails to :
> 
> lin...@li...
> 
> Which is the mailing list where all apus developper are subscribed, andwhere
> patches are supposed to be sent.
> 

OK. But how do I get from drivers/scsi/blz1230.c to the address of that
mailing list? It is not even in MAINTAINERS. And for the other appropriate
drivers in scsi/ ?

> I guess this list is mentioned in the appropriate place (but then what do you
> consider the appropriate places anyway, and where did you get Jesper's email
> address ? On some obsolete CD ort something such ?), and if not, Maybe we
> should add it there.

I got Jesper's mail address from the Copyright notice at the top of the
file. I hoped he would be kind enough to redirect me if he was not invol-
ved anymore. And he was :) (kind enough)
-- 
Regards,
        Rasmus(ra...@ja...)

You don't become a failure until you're satisfied with being one. 
  -- Anonymous

Re: 2.4.0

[T. <Ren...@gm...>]

Hi SVEN!

Sven LUTHER schrieb:

> Not sure, but that line don't seem complete, but then i may be wrong, having
> not looked at the code.
>
> scsi: detected total
>
> makes one think about :
>
> scsi: detected total 2 devices (or something such).
>
> What does the -test4 kernel say when there are no devices connected ?
>

That (and all other kernels) don't tell how many devices are connected (due to the
fact that no device is recocnized)! The other (2.4-)kernels don't even print that
line and some of the 2.2.10 kernels print rubbish into this line: There appears
parts of the text from two lines above in the console.

To all:

I forgot to mention that I played yesterday a little with the termination and some
RAM on the FASTLANE but the results didn't change! So I for myself do not belive
that it is a termination problem!

Kind Regards
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: [rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Sven L. <lu...@dp...>]

On Thu, Jan 18, 2001 at 10:05:24AM +0100, Rasmus Andersen wrote:
> Hi.
> 
> I have been asked by Jesper Skov to forward my patch below to these
> lists. He has also mentioned that there is supposed to be a maintainer
> for this code (a Sven Luther). Perhaps he should put his name the
> appropriate places?

Sorry, i am no more involved a lot right now, having no much time in this
moments.there are other people who took it over from me though.

Best is to send this kind of mails to :

lin...@li...

Which is the mailing list where all apus developper are subscribed, andwhere
patches are supposed to be sent.

I guess this list is mentioned in the appropriate place (but then what do you
consider the appropriate places anyway, and where did you get Jesper's email
address ? On some obsolete CD ort something such ?), and if not, Maybe we
should add it there.

I guess the web pages at the sourceforge linux-apus project contain all the
necessary information, and they are working since may 2000 or such.

Friendly,

Sven Luther

Re: 2.4.0

[Sven L. <lu...@dp...>]

On Wed, Jan 17, 2001 at 01:51:25PM +0100, Michel D=E4nzer wrote:
> Ren=E9 Thol wrote:
>=20
> > > If it boots without the HD, that really points towards a problem wi=
th
> > > connection and/or termination. Of course it could still be a bug in=
 the
> > > driver (especially if it still works with m68k), but if you have so=
me time
> > > to experiment... :)
> > >
> >=20
> > But the HD and CDROM connected to the FASTLANE work both under AmigaO=
S!?
>=20
> As Alan already mentioned, Linux is usually more picky about that sort =
of
> things. It's the best hardware testing software I know. :)
>=20
>=20
> > All of the 2.4 kernels do the same (I already posted the output), out=
 of the
> > 2.4-test4. That kernel boots a line further (scsi: detected total)!
>=20
> I don't expect that to mean too much, probably just a minor change in t=
he
> upper SCSI code.

Not sure, but that line don't seem complete, but then i may be wrong, hav=
ing
not looked at the code.

scsi: detected total

makes one think about :

scsi: detected total 2 devices (or something such).

What does the -test4 kernel say when there are no devices connected ?

Could it be that the number field, or whatever, containing the connected
devices is not correctly filed, thus hardboring a NULL pointer access or =
an
unallocated array entry access or something such ?

Friendly,

Sven Luther

Re: 2.4.0

[T. <Ren...@gm...>]

Hi over there!

Finally I got the kernels! Thanx to Michel and the ftp command within the
Windows-Console!

Bye
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: 2.4.0

[T. <Ren...@gm...>]

Hi again!

Addendum:

I forgot: WSFTP tells me: Can't get
"ftp://linux-apus.sourceforge.net/pub/linux-apus/test/" host entry!

And Netscape says: Remote server reset connection!

Bye
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: 2.4.0

[T. <Ren...@gm...>]

Hi Michel!

Michel Dänzer schrieb:

> I just clicked on the URL in Roman's mail and got the directory listing. Have
> you enabled using your e-mail address as password for anonymous FTP in the
> Netscape preferences?
>

I just enabled it, but no changes. Can't still get connected!

Bye
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: 2.4.0

[Michel <da...@re...>]

Ren=E9 Thol wrote:

> > > Unfortunately I get no connection to this server!!
> >
> > What's the problem? I just connected without any problems.
>=20
> Don't know! I never connected to the sourceforge ftp-server before! Do =
I
> have to login at sourceforge? I don't know! I tried connecting using
> Netscape and WSFTP! Both told me: Connection reset from remote
> host/Connection failed! I always tried to login as anonymous!

I just clicked on the URL in Roman's mail and got the directory listing. =
Have
you enabled using your e-mail address as password for anonymous FTP in th=
e
Netscape preferences?


Michel


--=20
Earthling Michel D=E4nzer (MrCooper)    \   Debian GNU/Linux (powerpc) de=
veloper
CS student, Free Software enthusiast   \        XFree86 and DRI project m=
ember

Re: 2.4.0

[T. <Ren...@gm...>]

Hi Michel!

Michel Dänzer schrieb:

> > Unfortunately I get no connection to this server!!
>
> What's the problem? I just connected without any problems.
>

Don't know! I never connected to the sourceforge ftp-server before! Do I have to
login at sourceforge? I don't know! I tried connecting using Netscape and WSFTP!
Both told me: Connection reset from remote host/Connection failed! I always tried
to login as anonymous!

Bye
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

[rasmus@jaquet.dk: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)]

[Rasmus A. <ra...@ja...>]

Hi.

I have been asked by Jesper Skov to forward my patch below to these
lists. He has also mentioned that there is supposed to be a maintainer
for this code (a Sven Luther). Perhaps he should put his name the
appropriate places?

Anyway, please comment the patches.

----- Forwarded message from Rasmus Andersen <ra...@ja...> -----

Delivered-To: ra...@ja...
Date:	Wed, 17 Jan 2001 23:13:53 +0100
From: Rasmus Andersen <ra...@ja...>
To: js...@cy...
Cc: lin...@vg...
Subject: [PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)
User-Agent: Mutt/1.2.4i
Precedence: bulk
X-Mailing-List:	lin...@vg...
X-Keywords:                 
X-UID: 18351

Hi.

The following patch makes drivers/scsi/blz1230.c check request_irq's
return code. It applies cleanly against 240p3 and ac9.

It also swaps two lines in an existing error path (esp_deallocate/
scsi_unregister) since this seems wrong.

Comments?


--- linux-ac9/drivers/scsi/blz1230.c.org	Sun Jan 14 19:58:47 2001
+++ linux-ac9/drivers/scsi/blz1230.c	Wed Jan 17 23:09:45 2001
@@ -88,13 +88,8 @@
 
 		esp_write(eregs->esp_cfg1, (ESP_CONFIG1_PENABLE | 7));
 		udelay(5);
-		if(esp_read(eregs->esp_cfg1) != (ESP_CONFIG1_PENABLE | 7)){
-			esp_deallocate(esp);
-			scsi_unregister(esp->ehost);
-			release_mem_region(board+REAL_BLZ1230_ESP_ADDR,
-					   sizeof(struct ESP_regs));
-			return 0; /* Bail out if address did not hold data */
-		}
+		if(esp_read(eregs->esp_cfg1) != (ESP_CONFIG1_PENABLE | 7))
+			goto err_out;
 
 		/* Do command transfer with programmed I/O */
 		esp->do_pio_cmds = 1;
@@ -140,8 +135,9 @@
 
 		esp->irq = IRQ_AMIGA_PORTS;
 		esp->slot = board+REAL_BLZ1230_ESP_ADDR;
-		request_irq(IRQ_AMIGA_PORTS, esp_intr, SA_SHIRQ,
-			    "Blizzard 1230 SCSI IV", esp_intr);
+		if (request_irq(IRQ_AMIGA_PORTS, esp_intr, SA_SHIRQ,
+				 "Blizzard 1230 SCSI IV", esp_intr))
+			goto err_out;
 
 		/* Figure out our scsi ID on the bus */
 		esp->scsi_id = 7;
@@ -156,6 +152,13 @@
 		return esps_in_use;
 	    }
 	}
+	return 0;
+ 
+ err_out:
+	scsi_unregister(esp->ehost);
+	esp_deallocate(esp);
+	release_mem_region(board+REAL_BLZ1230_ESP_ADDR,
+			   sizeof(struct ESP_regs));
 	return 0;
 }
 
-- 
Regards,
        Rasmus(ra...@ja...)

Half this game is ninety percent mental.
-Philadelphia Phillies manager Danny Ozark
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to maj...@vg...
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

Regards,
  Rasmus

Re: 2.4.0

[Michel <da...@re...>]

Ren=E9 Thol wrote:

> > > The last line I got only with the 2.4-test4 kernel! After this the
> > > cursor blinks all time in the next line AND (I forgot this) my powe=
r-led
> > > blinks regularly!!!
> >
> > I've put two kernels into
> > ftp://linux-apus.sourceforge.net/pub/linux-apus/test/.
> > vmlinux-2.4.0-m68k-fastlane.gz: is a m68k kernel to see whether it st=
ill
> > works here.
> > vmlinux-2.4.0-apus-fastlane-dbg.gz: with all debugging output enabled=
 I
> > could find. :)
>=20
> Unfortunately I get no connection to this server!!

What's the problem? I just connected without any problems.

> Can I get the files via http too?

Don't think so, it could put them up on my site though if you need that.


Michel


--=20
Earthling Michel D=E4nzer (MrCooper)    \   Debian GNU/Linux (powerpc) de=
veloper
CS student, Free Software enthusiast   \        XFree86 and DRI project m=
ember

Re: 2.4.0

[T. <Ren...@gm...>]

Hallo again!

Roman Zippel schrieb:

> Hi,
>
> On Wed, 17 Jan 2001, René Thol wrote:
>
> > The last line I got only with the 2.4-test4 kernel! After this the cursor
> > blinks all time in the next line AND (I forgot this) my power-led blinks
> > regularly!!!
>
> I've put two kernels into
> ftp://linux-apus.sourceforge.net/pub/linux-apus/test/.
> vmlinux-2.4.0-m68k-fastlane.gz: is a m68k kernel to see whether it still
> works here.
> vmlinux-2.4.0-apus-fastlane-dbg.gz: with all debugging output enabled I
> could find. :)

Unfortunately I get no connection to this server!! Can I get the files via http
too?

Regards
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

Re: 2.4.0

[T. <Ren...@gm...>]

Hi Roman!

Roman Zippel schrieb:

> I've put two kernels into
> ftp://linux-apus.sourceforge.net/pub/linux-apus/test/.
> vmlinux-2.4.0-m68k-fastlane.gz: is a m68k kernel to see whether it still
> works here.
> vmlinux-2.4.0-apus-fastlane-dbg.gz: with all debugging output enabled I
> could find. :)
>
> Ok, let's see what happens. :-)
>

Many thanx! Yeah let's see what will happen expecially with m68k!!!

Bye
--
========================
René Thol
------------------------------------
Multimedia Computing
University of Ulm
========================
E-Mail: Ren...@gm...
========================

CVS Update: 2.3

[Roman Z. <zi...@us...>]

CVSROOT:	/cvsroot/linux-apus
Module name:	2.3
Repository:	2.3/arch/ppc/
Changes by:	zippel@usw-pr-cvs1.	01/01/17 15:05:47

Modified files:
	2.3/arch/ppc/: config.in 

Log message:
	add pcmcia option

CVS Update: 2.3

[Roman Z. <zi...@us...>]

CVSROOT:	/cvsroot/linux-apus
Module name:	2.3
Repository:	2.3/arch/ppc/amiga/
Changes by:	zippel@usw-pr-cvs1.	01/01/17 15:04:54

Modified files:
	2.3/arch/ppc/amiga/: Makefile 

Log message:
	fix typo