From: Christian B. <don...@fr...> - 2010-12-09 10:06:48
|
Hi there again, This (quite big) patch here (http://dontmind.freeshell.org/tmp/0001-Update-minilzo-library-used-for-Ultra-encoding-to-ve.patch) updates the minilzo library used in both libvncserver and libvncclient to a recent version. Here's the changes: libvncclient/lzoconf.h | 420 ++--- libvncclient/lzodefs.h | 1851 ++++++++++++++++++ libvncclient/minilzo.c | 4987 ++++++++++++++++++++++++++++++------------------ libvncclient/minilzo.h | 26 +- libvncserver/lzoconf.h | 420 ++--- libvncserver/lzodefs.h | 1851 ++++++++++++++++++ libvncserver/minilzo.c | 4987 ++++++++++++++++++++++++++++++------------------ libvncserver/minilzo.h | 26 +- 8 files changed, 10368 insertions(+), 4200 deletions(-) create mode 100644 libvncclient/lzodefs.h create mode 100644 libvncserver/lzodefs.h Rationale: This should bring some speedup on 64-bit archs (according to the minilzo changelog here: http://www.oberhumer.com/opensource/lzo/lzonews.php.). More importantly though, it fixes a segfault inside the lzo_compress routine I had on my 64-bit machine while using a custom libvncserver/libvncclient. As you can see from the above change summary, the files in libvncserver and libvncclient are exactly the same. From a quick glance, there are some more files shared between the two (vncauth.c, d3des.c, zywrletemplate.c). Maybe it would be a good idea to introduce some thing like a 'shared' directory that contains files used by both libraries? Cheers, Christian |