Menu

#81 Fix NASM compilation

None
closed-accepted
nobody
None
5
2020-08-19
2018-03-19
No

Hi/2.

This is a patch for the regression after applying ticket #80.

Review, please...

1 Attachments

Discussion

  • Robert Hegemann

    Robert Hegemann - 2018-03-19

    What exactly is the problem now, is it the character encoding utf8?

     
  • KO Myung-Hun

    KO Myung-Hun - 2018-03-20

    I don't know. The character was not in my patch. Anyway here is the output of nasm.

    make.exe[3]: Entering directory `F:/lang/work/lame/lame.git/lame/libmp3lame/i386'
    echo '# Generated by ltmain.sh - GNU libtool 1.5.22 (1.1220.2.365 2005/12/18 22:14:06)' >choose_table.lo
    echo "pic_object='choose_table.o'" >>choose_table.lo
    echo "non_pic_object='choose_table.o'" >>choose_table.lo
    f:/apps/nasm -f aout -DAOUT -i ../../libmp3lame/i386/ choose_table.nas -o choose_table.o -l choose_table.lo.lst
    nasm.h:1: error: label or instruction expected at start of line
    choose_table.nas:24: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:78: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:102: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:109: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:341: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:353: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:414: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:426: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    choose_table.nas:447: warning: label alone on a line without a colon might be in error [-w+orphan-labels]
    make.exe[3]: *** [choose_table.lo] Error 1
    make.exe[3]: Leaving directory `F:/lang/work/lame/lame.git/lame/libmp3lame/i386'
    
     
  • KO Myung-Hun

    KO Myung-Hun - 2018-05-22

    Ok. it was UTF-8 BOM. And CP949 is used, here.

     
  • Alexander Leidinger

    • status: open --> closed-accepted
    • Group: -->
     
  • Alexander Leidinger

    Committed.

     

Log in to post a comment.