[Kprof-develop] RE: KProf / patches

[Desmond, C. <Col...@lo...>]

I have applied the patches to the CVS tree, but on my system (Gentoo), I ca=
nnot build it as there is something terminally wrong with the autoconf stuf=
f. If anyone knows how to fix this, I'd be very grateful!

Colin


-----Original Message-----
From: Jeremy Laine [mailto:jer...@m4...]
Sent: Fri 02/09/2005 11:53
To: Desmond, Colin; kpr...@li...
Cc: Florent Pillet; Ben Burton; Ross Boylan
Subject: KProf / patches
=20
Hi Colin!

> I will try and take a look at this at the weekend. Thanks Jeremy for poin=
ting
> out these issues with the code.

Attached are 3 patches I am planning to include in the next Debian upload of
KProf:

- 01 : fix for a compilation error related to QTextStream
- 02 : fix for the memory error I mentioned in my previous message (spotted=
 with
valgrind)
- 03 : fix for the way KProf calculates "total" times based on gprof output.
This bug was reported some time ago by Ross Boylan  :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D282137

This third patch is not optimised in terms of processor time as it makes an
extra call to "locateProfileEntry" for each primary entry in the gprof call
tree. A better patch could be produced by having
CParseProfile::processCallGraphBlock" return a pointer to the CProfileInfo =
for
the primary entry.

I suggest we move this discussion to kpr...@li... to
avoid excessive Cc'ing :)

Cheers,
Jeremy

--
http://www.jerryweb.org/             : JerryWeb.org
http://sailcut.sourceforge.net/      : Sailcut CAD
http://opensource.polytechnique.org/ : Polytechnique.org Free Software



This e-mail and any attachment is for authorised use by the intended recipi=
ent(s) only. It may contain proprietary material, confidential information =
and/or be subject to legal privilege. It should not be copied, disclosed to=
, retained or used by, any other party. If you are not an intended recipien=
t then please promptly delete this e-mail and any attachment and all copies=
 and inform the sender. Thank you.