#108 fix(dbt): unblock governed consolidation build on real D365 data (#105)

[Anonymous]

Originally created by: grynn-in

Problem

Fixes [#105]. The konsol governed build runs dbt build (models + tests), so a failing test skips all models downstream of it. On real D365 data two tests failed → every consolidation gold model was SKIPPED → the "Run Pipeline" button can never complete.

Fixes

1. Entity-less GL rows — ~11% of real D365 GL headers have an empty SubledgerVoucherDataAreaId → entity_id = ''. They can't be attributed to a legal entity or consolidated, and they fail test_canonical_gl_entries_not_null. Filtered out in the canonical models/staging/canonical/stg_gl_entries.sql (where coalesce(entity_id,'') != '').
2. currencies seed not in scope — +tag:domain:consolidation pulled in assert_exchange_rate_currencies_are_iso (attached to silver_exchange_rates) but not the currencies seed it references → UNKNOWN_TABLE. Tagged the seed domain:consolidation in dbt_project.yml, and expanded currencies.csv with 22 ISO 4217 codes the real D365 FX data uses (ALL, AMD, ANG, AZN, BDT, BGN, BOB, CUP, DZD, ETB, GEL, KGS, KZT, MDL, MMK, MNT, NGN, RSD, TJS, TMT, UZS, XDR).

Verification (real D365 data)

dbt build --select +tag:domain:consolidation:

• test_canonical_gl_entries_not_null → PASS (was FAIL 55,979)
• assert_exchange_rate_currencies_are_iso → PASS (was ERROR UNKNOWN_TABLE, then FAIL 22 → seed expanded)
• Governed-build errors 2 → 1.

Out of scope (follow-up)

Resolving the two above surfaced a previously-masked failure: assert_fiscal_calendar_is_loaded (5 entities with GL data whose fiscal_calendar_id is absent from silver_fiscal_periods). Different root cause (fiscal-calendar coverage), tracked separately.

🤖 Generated with Claude Code

[Anonymous]

Ticket changed by: grynn-in

• status: open --> closed