It seems like quite a few sites that show valid favicons in my browser fail to download with this plugin. So far, they all seem to fall under 3 error message. Here is an example site of each error message, all of which do show favicons properly in my browser:
1) "Parameter is not valid" generally indicates an invalid icon. While it is possible that web browsers are able to display the invalid icon and this plugin can not, the more common explanation (as in this specific case) is that the plugin is selecting a different icon than the browser. For this example, the new version will now select the same icon as the browser and it therefore works correctly.
2) Ironically, this website is not beautiful. Specifically, they have invalid source code (multiple spaces where there should be only one per https://html5.org/r/6404). Having re-read the relevant spec I've slightly tweaked the plugin to tolerate this "ugly" situation.
3) This specific example fails because the website incorrectly assumes that all requests will specify a prefered language. I've made sure that the plugin now explicitly states that it will accept any language.
I am certain that all three of those error categories will continue to occur for some websites but hopefully this batch of improvements will fix at least a fair number of them.
Thanks,
Chris
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Awesome, thanks for the unbelievably quick turnaround! I've updated; here's one more unique error I overlooked previously:
https://youbike.com.tw ("SendFailure: The underlying connection was closed: An unexpected error occurred on a send.")
Also, this isn't so much of an error, but perhaps something to consider. I've got an entry for accounts.intuit.com; they don't have a favicon on that subdomain, but do on the main domain, www.intuit.com. Similarly, profiles.burningman.com vs www.burningman.com, mypage.bmobile.ne.jp vs www.bmobile.ne.jp, gearshop.dpreview.com vs www.dpreview.com, etc (there are dozens of such examples in my password list).
Perhaps it could be an option to fallback on the main domain if a favicon can't be found on the subdomain? :)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Doesn't appear as though the auther is maintaining his plugin any longer, but for what it's worth, the downloader fails anytime there's https:// in the url. Changing them to http:// fixes many issues.
It seems like quite a few sites that show valid favicons in my browser fail to download with this plugin. So far, they all seem to fall under 3 error message. Here is an example site of each error message, all of which do show favicons properly in my browser:
http://www.justin-klein.com (parameter is not valid)
http://www.beautifulpeople.com (404)
http://www.iherb.com (403)
Those all now work in v1.9.0
1) "Parameter is not valid" generally indicates an invalid icon. While it is possible that web browsers are able to display the invalid icon and this plugin can not, the more common explanation (as in this specific case) is that the plugin is selecting a different icon than the browser. For this example, the new version will now select the same icon as the browser and it therefore works correctly.
2) Ironically, this website is not beautiful. Specifically, they have invalid source code (multiple spaces where there should be only one per https://html5.org/r/6404). Having re-read the relevant spec I've slightly tweaked the plugin to tolerate this "ugly" situation.
3) This specific example fails because the website incorrectly assumes that all requests will specify a prefered language. I've made sure that the plugin now explicitly states that it will accept any language.
I am certain that all three of those error categories will continue to occur for some websites but hopefully this batch of improvements will fix at least a fair number of them.
Thanks,
Chris
Awesome, thanks for the unbelievably quick turnaround! I've updated; here's one more unique error I overlooked previously:
https://youbike.com.tw ("SendFailure: The underlying connection was closed: An unexpected error occurred on a send.")
Also, this isn't so much of an error, but perhaps something to consider. I've got an entry for accounts.intuit.com; they don't have a favicon on that subdomain, but do on the main domain, www.intuit.com. Similarly, profiles.burningman.com vs www.burningman.com, mypage.bmobile.ne.jp vs www.bmobile.ne.jp, gearshop.dpreview.com vs www.dpreview.com, etc (there are dozens of such examples in my password list).
Perhaps it could be an option to fallback on the main domain if a favicon can't be found on the subdomain? :)
...And a few more that do work in the browser:
https://blueshieldca.com (404)
http://www.whynotjapan.com (404)
http://www.opencart.com (404)
http://www.chatroulette.com (parameter is not valid)
Last edit: pixelstuff 2015-09-25
Having a similar problem with:
http://www.geni.com/
Doesn't appear as though the auther is maintaining his plugin any longer, but for what it's worth, the downloader fails anytime there's https:// in the url. Changing them to http:// fixes many issues.
(There are still some that don't work either way, however - i.e. http://whynotjapan.com, http://chatroulette.com, etc).