From: SourceForge.net <no...@so...> - 2007-11-25 19:55:00
|
Patches item #1838063, was opened at 2007-11-25 08:26 Message generated for change (Comment added) made by cgroves You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1838063&group_id=12867 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dan (dohuiginn) Assigned to: Nobody/Anonymous (nobody) Summary: Patch for [1796425] [1796415] javaos.py renames/removedirs Initial Comment: Patch to fix the issues reported in [1796425] and [1796415] - javaos is missing the renames and removedirs functions. I've copied the functions over from CPython (2.5) and they seem to work fine. Since this is the first patch I've submitted to jython, I'd appreciate advice/comments on what's required here. e.g. is the diff in the right format? should I write a test to go with the patch? ---------------------------------------------------------------------- >Comment By: Charles Groves (cgroves) Date: 2007-11-25 14:54 Message: Logged In: YES user_id=1174327 Originator: NO Having tests for the patch makes it easier to apply them, so they're definitely encouraged. http://wiki.python.org/jython/PatchGuidelines has some basic guidelines for patches for Jython. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1838063&group_id=12867 |