[Jython-bugs] [ jython-Patches-1761111 ] Patch for PEP 292 Simpler String Substitutions

[SourceForge.net <no...@so...>]

Patches item #1761111, was opened at 2007-07-26 13:26
Message generated for change (Comment added) made by rajesh_battala
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1761111&group_id=12867

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: rajesh battala (rajesh_battala)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for PEP 292 Simpler String Substitutions

Initial Comment:
hi all
i am attaching a tar which contains the patch for the PEP292 and test program for that.
thanks
rajesh.battala

----------------------------------------------------------------------

>Comment By: rajesh battala (rajesh_battala)
Date: 2007-08-16 07:10

Message:
Logged In: YES 
user_id=1851210
Originator: YES

File Added: test_pep292.py

----------------------------------------------------------------------

Comment By: rajesh battala (rajesh_battala)
Date: 2007-08-16 07:09

Message:
Logged In: YES 
user_id=1851210
Originator: YES

hi
i am attaching the patch for the String PEP292.
The test case file for this moudle is a new file test_pep292.py
so i am attaching it seperately.
thanks

File Added: pep292.patch

----------------------------------------------------------------------

Comment By: Charles Groves (cgroves)
Date: 2007-08-12 05:53

Message:
Logged In: YES 
user_id=1174327
Originator: NO

Hi Rajesh,

The patch seems to have lost the test file you included the first time. 
See http://wiki.python.org/jython/PatchGuidelines for instructions on how
to produce a diff that includes your changes to string.py and the test
file.

----------------------------------------------------------------------

Comment By: rajesh battala (rajesh_battala)
Date: 2007-07-31 04:33

Message:
Logged In: YES 
user_id=1851210
Originator: YES

hi Charles Groves
this is the svn location 
http://svn.python.org/projects/python/branches/release24-maint revision
56629
and the file string.py is located in Lib
i have added the comments suggested my fwierzbicki in the patch.
i am submitting the patch as a single file
thanks.

File Added: pep292.patch

----------------------------------------------------------------------

Comment By: rajesh battala (rajesh_battala)
Date: 2007-07-31 03:52

Message:
Logged In: YES 
user_id=1851210
Originator: YES

hi fwierzbicki
thanks a lot for the important useful comment


----------------------------------------------------------------------

Comment By: Frank Wierzbicki (fwierzbicki)
Date: 2007-07-30 13:43

Message:
Logged In: YES 
user_id=193969
Originator: NO

rajesh_battala,

The svn location of the CPython 2.4 maintenance branch is:
http://svn.python.org/projects/python/branches/release24-maint

if you could check that out like so:

svn co http://svn.python.org/projects/python/branches/release24-maint

and confirm that your diff is the same against this and include a comment
like:

#XXX: copied from
http://svn.python.org/projects/python/branches/release24-maint revision
56629

That would help.

----------------------------------------------------------------------

Comment By: rajesh battala (rajesh_battala)
Date: 2007-07-30 05:16

Message:
Logged In: YES 
user_id=1851210
Originator: YES

hi charles.
i have taken that implementation from python version of 2.4
from python2.4 source ihave taken not from the svn repository. so, i am
not sure of svn url and revision
i am attaching the patch. and it has to merge in Lib/string.py

thanks
File Added: pep292.patch

----------------------------------------------------------------------

Comment By: Charles Groves (cgroves)
Date: 2007-07-30 04:45

Message:
Logged In: YES 
user_id=1174327
Originator: NO

This appears to be the PEP 292 stuff straight out of CPython.  That's
definitely the way to go, but I need to know the svn url and revision where
you got this.  We track when stuff came over from CPython so as we catch up
to their current version we can just depend on that directly rather than
having our own version in Jython.

Also, please submit this as a single patch file rather than as a tar.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1761111&group_id=12867