Re: [Jython-dev] problem with multi level import

[<Mat...@i2...>]

On 12/19/2001 02:06:17 PM jython-dev-admin wrote:
>
> >If I have to do more complicated changes, whats the best way for me to
> >generate a patch?
> 
> 1) Check out the CVS version.
> 2) Edit the sources until it works for you.
> 3) run "cvs diff -u" to generate a patch.
> 4) Add the patch on SF.
>    http://sourceforge.net/tracker/?group_id=12867&atid=312867
> 5) [Most important] Do not post the patch to a mailing list.

Ok, cool, thanks for the info - I just fixed a problem with jreload 
(ClassFormatError due to truncated class data because when loading the 
class from the stream, it does a single read instead of looping reads till 
EOS), so I'll submit that patch using SF sometime today.
I assume that when doing a "cvs diff -u", I should do a "clean" build 
first so that none of the build cruft shows up in the patch?
Also, if I know that I only changed a single source file, can I do the 
"cvs diff -c" on just that file?  Does the current directory matter when 
doing the diff, or can I be in the directory containing the file? i.e. 
which of the following is preferred:
"cvs diff -c jython/org/python/core/imp.java"
or
"cd jython/org/python/core; cvs diff -c imp.java"

> If you *really* want to help out, you should have made a SF bug report
> with your observation (there is still time to make amends <wink>) and a

Heh, ok, if I get a chance today I'll do it, lots to get done before my 
vacation starts so no guarantees =)

Matt