Re: [Jython-dev] zip files on sys.path

[Samuele P. <pe...@in...>]

Hi,

I have checked the code of your 2nd patch  (but yet not tried it).
The patch is neat, but here are some comments:

> The magic string -> SyspathArchive works on all paths of this form, but
> it will cause the archive to be opened each such a string is found on
> sys.path. Hardly a problem I think.
I don't know if that's a problem or not, but in case a central
cache with a (incredible under java) simple ref count logic can do the job.
I propose ref counting because weak-refs work only under Java2.

The logic for detecting a jar!relpath entry seems a bit weak, if the user
have paths around containing a !. Insane, of course, but ...

Maybe SysArchives should have an archive_close method (in case), closing
the zip or playing well with the central cache.

The final point: imp has always been a bit messy (I always wanted to
polish it a bit ..), and now loadFromZipFile adds another amount of code
duplication wrt loadFromPath ...
so I would prefer things factored in another way...
in case I can do that.

Samuele.