Re: [Jython-dev] nested scopes (2)

[<bc...@wo...>]

[Samuele]

>Hi.
> 
>I have just posted to SF two patches (for review):
>* one completes the interpreter support for nested scopes: nested scopes
>semantic settings should be properly inherited through exec,execfile, etc .
>It passes  the usual tests.

It also passes whatever tests I have. 

My single comment is concerning the CompilerFlags class which I feel
should now be placed in the org.python.core package. That way it will be
included in jar file when compiling with the --core option. I found that
to be necessary for the 1.3 appletviewer.

>* the other adds nested scopes support to jythonc (see descr. and comments)

Looks good. Obviously my tests are woefully short of any use of nested
scopes, but there was no negative sideeffect with the jythonc patches.

I'm very impressed with the changes to jythonc. Despite the added
complexity of nested scopes, I feel that the result have become easier
to understand.

Feel free to commit these two patches and close the bug reports at your
convenience.

regards,
finn