From: Pekka L. <pe...@ik...> - 2007-07-20 08:10:22
|
2007/7/19, Alan Kennedy <jyt...@xh...>: > [Alan] > >> Looking forward to RC3. > > [Pekka] > > Me too. Will your select.cpython_compatible_select be included? > > Checked in and ready to go. I tested a simple telnet example (the same as in bug report at http://jython.org/1755096) and after adding "import select; select.select = cpython_compatible_select" it run successfully. My telnet needs are pretty simple and now that this example works I'm quite sure everything else that is needed works also. Thank you, again, Alan!! I'm still wondering should telnetlib be patched so that it would use cpython_compatible_select automatically. Since even the simplest possible example fails without it, it's hard to imagine the change would cause any more problems. Workaround to re-assign select.select is also slightly problematic because after that all other code using select.select will use cpython_compatible_select instead of the default select. If telnetlib is changed to have "from select import cpython_compatible_select as select", then at least the simple case would work. In this case it would be still possible to use "telnetlib.select = select.select" in code using telnetlib to get Jython's normal select to use. Alternatively, simply changing "import select" to "from select import select" in telnetlib would allow "telnetlib.select = select.cpython_compatible_select" which wouldn't alter normal select.select. Cheers, .peke |