From: Alan K. <jyt...@xh...> - 2007-06-20 18:29:45
|
[Oti] > 17 tests failed: > test_atexit test_cpickle test_descr test_frozen test_marshal > test_new test_pickle test_pkgimport test_poll test_profilehooks > test_pyclbr test_select test_socket test_sre test_threaded_import > test_trace test_weakref > 3 fails unexpected on java1.6.0_01: > test_select test_socket test_poll The cpython test_poll module is of no use on jython. It tests non-blocking IO on pipes, which are not supported by the new select module, and mostly tests poll event types that are not supported on jython (because they're not supported on java), namely POLLNVAL, POLLHUP, etc. One of these days I will rewrite the cpython test_poll module to test meaningful things on jython. In the meantime, I am happy that the poll implementation on jython is well tested: the select.select function is implemented on top of a select.poll object, and select.select is extensively tested. As for test_socket and test_select, hmmmm. I've just run all of the tests on java 1.6.0_01, and they all pass, i.e. run successfully. I think the failures are probably to do with how the modules are integrated into the overall test suite, and automated running of same. When I was porting test_socket and test_select from cpython 2.4, I commented out all references to the overall test environment, because I was developing on jython 2.1, which had an incompatible interface in the test_support module, for example. So all three of the test modules I updated/contributed (test_socket, test_select and test_select_new) were written to run standalone, and that's how I've been running them all through the development cycle. If you let me know how you've run the above tests, and/or point me to any documentation that describes how to integrate unit test modules, I'll do the work to integrate the modules into the overall unittest environment. To summarise, the tests in question all run 100% successfully on jdk1.6.0_01, when run manually. So I don't consider this to be a showstopper for the (tremendously exciting!) 2.2rc1 which Charlie is proposing. Regards, Alan. |