Re: [Jython-dev] UnicodeType defined as PyString in types.java

[Matt S. <ms...@ac...>]

I've gone ahead and checked this in, as it's necessary for pickle.  It's 
part of revision 2856.  If anything looks fishy, please let me know.

Matt Small wrote:
> I noticed this while I was cleaning up some more pickle tests.  In 
> types.java (the Python types module), UnicodeType is defined as 
> PyString.class.  It seems to me like it should be defined as 
> PyUnicode.class.
> 
> The change looks good to me, and it lets me pickle unicode strings, but 
> maybe someone who knows more about this could let me know if it really 
> makes sense?
> 
> Thanks,
> Matt
> 
> 
> ------------------------------------------------------------------------
> 
> Index: src/org/python/modules/types.java
> ===================================================================
> --- src/org/python/modules/types.java	(revision 2854)
> +++ src/org/python/modules/types.java	(working copy)
> @@ -51,7 +51,7 @@
>          dict.__setitem__("TypeType", PyType.fromClass(PyType.class));
>          dict.__setitem__("UnboundMethodType",
>                           PyType.fromClass(PyMethod.class));
> -        dict.__setitem__("UnicodeType", PyType.fromClass(PyString.class));
> +        dict.__setitem__("UnicodeType", PyType.fromClass(PyUnicode.class));
>          dict.__setitem__("XRangeType", PyType.fromClass(PyXRange.class));
>  
>          dict.__setitem__("StringTypes", new PyTuple(new PyObject[] {
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Jython-dev mailing list
> Jyt...@li...
> https://lists.sourceforge.net/lists/listinfo/jython-dev