Re: [Junit-devel] Suggestion

[Alan C F. <al...@tw...>]

I've done a full-scale refactor of ComparisonFailure, but it's not finished
yet.  During this excavation I found a bug.  It's not a desperately tidy
fix...

Since I'm unwise in the way of diffs and patches......

I added these tests to junit.tests.framework.AssertTest

   public void testComparisonErrorWithExpectedNull() {
      ComparisonFailure failure= new ComparisonFailure(null, null, "abcde");
      assertEquals("expected:<null> but was:<abcde>", failure.getMessage());
   }

   public void testComparisonErrorWithActualNull() {
      ComparisonFailure failure= new ComparisonFailure(null, "abcde", null);
      assertEquals("expected:<abcde> but was:<null>", failure.getMessage());
   }

   public void testComparisonErrorWithExpectedAndActualNull() {
      ComparisonFailure failure= new ComparisonFailure(null, null, null);
      assertEquals("expected:<null> but was:<null>", failure.getMessage());
   }


And added this code at line 33 of the existing version of
ComparisonFailure.java, after
  String message= super.getMessage();

      if( fExpected == null || fActual == null )
      {
         if (message != null)
            formatted= message+": ";
         return formatted+"expected:<"+fExpected+"> but was:<"+fActual+">";
      }

Alan
--------------------------------------------------------------------
A l a n  F r a n c i s | Training, Mentoring, Coaching, Development
t w e l v e 7 1 . c o m| Object Oriented Design, Extreme Programming
--------------------------------------------------------------------
I don't think it means what you think it means -- Inigo Montoya