Re: [Jts-topo-suite-user] adding Geometry.equals(Object) method (was: fixing bugs)
Brought to you by:
dr_jts
From: Gabriel R. <gr...@op...> - 2011-01-31 07:58:52
|
Hey when you have a prototype I'd be glad to get a jar so I can run a geotools build against it and make sure no test break. So if you wan to do that don't hesitate to send me the prototype jar. Cheers, Gabriel On Fri, 2011-01-28 at 15:07 -0800, Martin Davis wrote: > Good to hear that, Gabriel. If this is a safe change for GeoTools, > there's a very good chance that it will be safe for most or all other > users as well. > > I plan to start prototyping this ASAP. > > On Fri, Jan 28, 2011 at 1:47 PM, Gabriel Roldán <gr...@op...> > wrote: > I know every place where we needed an equals comparison in the > GeoTools > library we're explicitly casting to Geometry so it's a safe > change for > us too. And a welcomed one. > > Cheers, > Gabriel > > > On Fri, 2011-01-28 at 13:38 -0800, Martin Davis wrote: > > Ok, I'm convinced! > > > > Anyone else got comments or concerns? Now's the time to > speak up... > > > > On Fri, Jan 28, 2011 at 1:36 PM, Smiley, David W. > <ds...@mi...> > > wrote: > > On Jan 28, 2011, at 4:20 PM, Martin Davis wrote: > > > > > It's that people may be using the current equals > to > > determine topological equality, and might suddenly > find this > > changing to be exact equality. > > > > > > That wouldn't happen (see below for explaination). > What is > > proposed to change, is equals(Object). > > > > > Although as I said, maybe there is no risk since > they must > > also currently be explicitly ensuring the argument > is typed as > > Geometry - in which things will still work. > > > > > > Java being a typed language, the method to invoke is > resolved > > at compile time. If they were calling > equals(Geometry), they > > will continue to do so (and it will be marked > henceforth as > > deprecated in favor of equalsGeometry() which I > think is a > > good idea). This ads a bit of > safety/reproducibility that > > other dynamic method invocation languages do not > enjoy. > > > > > > ~ David > > > > > > > ------------------------------------------------------------------------------ > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD > value)! > > Finally, a world-class log management solution at an even > better price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer > expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > _______________________________________________ > Jts-topo-suite-user mailing list > Jts...@li... > https://lists.sourceforge.net/lists/listinfo/jts-topo-suite-user > > > -- > Gabriel Roldan > gr...@op... > Expert service straight from the developers > > -- Gabriel Roldan gr...@op... Expert service straight from the developers |