Re: [Jpype-users] minor patch for linux

[Jorge N. <nie...@gm...>]

Hello Miguel:

On Tue, Dec 27, 2011 at 8:04 AM, Linos <in...@li...> wrote:

> Hi,
>        i have added this patch request
>
> https://sourceforge.net/tracker/?func=detail&aid=3465996&group_id=109824&atid=655014
> for a small improve in the way the libjvm.so path in linux it is detected,
> if
> anyone it is using JPype in linux with many different distros probably
> would be
> of help.
>
> Regards,
> Miguel Angel.
>


I think that using a forced SubProcess invoking 2 (possible blocking
commands) as first step to find the library path isn't a good idea for
Jpype. This is portable to FreeBSD/Others (lsof?) ? . BTW I think that the
_getJVMFromJavaHome and _getJVMFromLibPath are enough.

If you will continue using the JavaBin A small fix to your patch:

+  proc = subprocess.Popen("%s &>/dev/null| %s -c java 2>/dev/null" %
(java_path, lsof_path), shell=True, stdout=subprocess.PIPE)


Greetings,

-- 
Jorge Niedbalski R.
--------------------------