Menu

#43 "Open image with" command always passes a short filename

V1.0.12
closed-fixed
nobody
bugs (1)
5
2015-01-03
2014-11-19
DukeDog
No

"Open image with" command always passes a short filename.
OpenWith0="Cmd: 'cmd /K echo %filename%' Menuitem: 'Command Prompt' Flags: 'ShellExecute'"

above result:cmd

In UserCommand.cpp->#292

if (m_sCommand.Find(_T("jpegtran ")) == 1) {
sFileNameInCommandLine = Helpers::ReplacePathByShortForm(sFileName);
}

When commentout this, It operated well.

1 Attachments

Discussion

  • David Kleiner

    David Kleiner - 2014-11-22

    I removed that code as it is legacy - jpegtran is neither needed nor supported anymore. Lossless JPEG transformations are supported directly.
    However I wonder why removing this code helped on your system because

    • I tried your command before I removed this code and the output was a long file name
    • That is not surprising because the short file name is only used when the command starts with the string 'jpegtran' what is not the case with your command.
     
  • DukeDog

    DukeDog - 2014-11-22

    Opps!
    I mistook the code to upload. Above is the code which I modified.
    Original code is like this.

    if (m_sCommand.Find(_T("jpegtran ")) == 0) {
        sFileNameInCommandLine = Helpers::ReplacePathByShortForm(sFileName);
    }
    
     

    Last edit: DukeDog 2014-11-23
  • David Kleiner

    David Kleiner - 2015-01-03
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB