Re: [Jikesrvm-core] [Jikesrvm-commits] SF.net SVN: jikesrvm: [12849] rvmroot/trunk/rvm/src/org/jikesrvm/compilers/ opt/OPT_Simplifier.java

[Daniel F. <zyr...@zy...>]

Perhaps we should change typeRef.isResolved to typeRef.isLoaded. Since
this is what it actually means.. And then we can add a
typeRef.isResolved that includes this condition rather than propagating
it everywhere.

Cheers,
Daniel.

-----Original Message-----
From: jik...@li...
[mailto:jik...@li...] On Behalf Of
pet...@us...
Sent: Saturday, 30 June 2007 2:13 PM
To: jik...@li...
Subject: [Jikesrvm-commits] SF.net SVN: jikesrvm: [12849]
rvmroot/trunk/rvm/src/org/jikesrvm/compilers/ opt/OPT_Simplifier.java

Revision: 12849
          http://svn.sourceforge.net/jikesrvm/?rev=3D12849&view=3Drev
Author:   peter_donald
Date:     2007-06-29 21:12:58 -0700 (Fri, 29 Jun 2007)

Log Message:
-----------
To correctly fold tib values the type must be resolved, not just type
reference.=20

Note: This is not currently run as tib folding is disabled

Modified Paths:
--------------
    rvmroot/trunk/rvm/src/org/jikesrvm/compilers/opt/OPT_Simplifier.java

Modified:
rvmroot/trunk/rvm/src/org/jikesrvm/compilers/opt/OPT_Simplifier.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- rvmroot/trunk/rvm/src/org/jikesrvm/compilers/opt/OPT_Simplifier.java
2007-06-30 04:09:26 UTC (rev 12848)
+++ rvmroot/trunk/rvm/src/org/jikesrvm/compilers/opt/OPT_Simplifier.java
2007-06-30 04:12:58 UTC (rev 12849)
@@ -3413,7 +3413,7 @@
       } else {
         OPT_RegisterOperand rop =3D op.asRegister();
         VM_TypeReference typeRef =3D rop.getType();
-        if (typeRef.isResolved() && rop.isPreciseType()) {
+        if (typeRef.isResolved() &&
typeRef.peekResolvedType().isResolved() && rop.isPreciseType()) {
           Move.mutate(s,
                       REF_MOVE,
                       GuardedUnary.getClearResult(s),
@@ -3428,7 +3428,7 @@
   private static DefUseEffect getClassTib(OPT_Instruction s) {
     if (CF_TIB) {
       OPT_TypeOperand typeOp =3D Unary.getVal(s).asType();
-      if (typeOp.getTypeRef().isResolved()) {
+      if (typeOp.getTypeRef().isResolved() &&
typeOp.getTypeRef().peekResolvedType().isResolved()) {
         Move.mutate(s,
                     REF_MOVE,
                     Unary.getClearResult(s),


This was sent by the SourceForge.net collaborative development platform,
the world's largest Open Source development site.

------------------------------------------------------------------------
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jikesrvm-commits mailing list
Jik...@li...
https://lists.sourceforge.net/lists/listinfo/jikesrvm-commits