From: Erik B. (JIRA) <ji...@xt...> - 2017-05-29 13:10:56
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0"> <base href="https://xtenlang.atlassian.net"> <title>Message Title</title> </head> <body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429"> <table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"> <!-- header here --> <tbody> <tr> <td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px"> <table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/0d83a9e7bcd626cc4b4d9eb9d9955287?s=48&d=https%3A%2F%2Fxtenlang.atlassian.net%2Fsecure%2Fuseravatar%3FavatarId%3D10123%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td> <td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="ebrangs" id="email_ebrangs" href="https://xtenlang.atlassian.net/secure/ViewProfile.jspa?name=ebrangs" style="color:#3b73af;; color: #3b73af; text-decoration: none">Erik Brangs</a> <strong>commented</strong> on <a href="https://xtenlang.atlassian.net/browse/RVM-1154" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-a9dc0fe6-92c7-4c5a-8db2-ad98c3c3823e" height="16" width="16" border="0" align="absmiddle" alt="Bug"> RVM-1154</a> </td> </tr> </tbody> </table> </td> </tr> <tr> <td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px"> <table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate"> <tbody> <tr> <!-- there needs to be content in the cell for it to render in some clients --> <td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://xtenlang.atlassian.net/browse/RVM-1154" style="color: #3b73af; text-decoration: none">Re: x64 assertion failure in FragmentedMmapper.slabTableFor(...)</a> </span> </td> </tr> </tbody> </table> </td> </tr> <tr> <td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff"> <table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px"> <tbody> <tr> <td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">Additionally, shouldn't statements (X) and (Y) be switched? After all, it is theorethically possible that the write from (X) is propagated before (Y) even if that's currently not happening. </p> <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0"> <div class="codeContent panelContent" style="padding: 9px 12px"> <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal"> <span class="code-keyword" style="color: #000091">if</span> (map[i] == base) <span class="code-keyword" style="color: #000091">return</span> slab[i]; <span class="code-comment" style="color: #808080">// (1) </span>lock.acquire(); <span class="code-keyword" style="color: #000091">if</span> (map[i] == base) { lock.release(); <span class="code-keyword" style="color: #000091">return</span> slab[i]; } map[i] = base; <span class="code-comment" style="color: #808080">// (X) </span>slab[i] = free_slabs[j++]; <span class="code-comment" style="color: #808080">// (Y) </span>lock.release(); <span class="code-keyword" style="color: #000091">return</span> slab[i]; <span class="code-comment" style="color: #808080">// (2)</span> </pre> </div> </div> </td> </tr> </tbody> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json"> { "@context": "http://schema.org", "@type": "EmailMessage", "description": "View Issue", "potentialAction": { "@type": "ViewAction", "target": "https://xtenlang.atlassian.net/browse/RVM-1154?inbox=true&focusedCommentId=37603&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-37603", "name": "View Comment" }, "publisher": { "@type": "Organization", "name": "Atlassian", "url": "https://www.atlassian.com" } } </script> <table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <tbody> <tr> <td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0"> <table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://xtenlang.atlassian.net/browse/RVM-1154#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-8c8050c8-cd35-48d5-a444-6b6766323122" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td> <td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://xtenlang.atlassian.net/browse/RVM-1154#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td> </tr> </tbody> </table> </td> </tr> </tbody> </table> </td> </tr> <!-- there needs to be content in the cell for it to render in some clients --> <tr> <td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td> </tr> </tbody> </table> </td> </tr> <tr> <td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px"> <table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.1010.1#100044-<span title="669d9b4c7ef31d2dc83da83b215f0403dc644ee9" data-commit-id="669d9b4c7ef31d2dc83da83b215f0403dc644ee9}">sha1:669d9b4</span>)</span> </td> <td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top"> <table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-ad161f81-f7fb-4d93-9001-fc1b82318da3" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td> </tr> </tbody> </table> </td> </tr> </tbody> </table> </td> </tr> </tbody> </table> </body> </html> |