[rvm-commits] code: Only show output for eager mmapping of discontigous spaces...

[<jik...@li...>]

details:   http://hg.code.sourceforge.net/p/jikesrvm/code/rev/cb7133a8b9ca
changeset: 10743:cb7133a8b9ca
user:      Erik Brangs <eri...@gm...>
date:      Tue Apr 15 20:53:27 2014 +0200
description:
Only show output for eager mmapping of discontigous spaces when the verbosity level is high enough.

The old behaviour is inconsistent with the eager mmaping of contigous spaces which only shows printouts when the verbosity level is > 2.

Moreover, the option -X:gc:eagerMmapSpaces=true may be necessary on some platforms to ensure that the operating system and MMTk have the same view about available memory. On those platforms, it is useful if there's no additional output when using -X:gc:eagerMmapSpaces=true because that means that test cases with checksum-based output verification work without adjustments.


diffstat:

 MMTk/src/org/mmtk/policy/Space.java |  10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diffs (20 lines):

diff --git a/MMTk/src/org/mmtk/policy/Space.java b/MMTk/src/org/mmtk/policy/Space.java
--- a/MMTk/src/org/mmtk/policy/Space.java
+++ b/MMTk/src/org/mmtk/policy/Space.java
@@ -645,10 +645,12 @@
     Address regionStart = Space.getDiscontigStart();
     Address regionEnd = Space.getDiscontigEnd();
     int pages = regionEnd.diff(regionStart).toInt()>>LOG_BYTES_IN_PAGE;
-    Log.write("Mapping discontiguous spaces ");
-    Log.write(regionStart);
-    Log.write("->");
-    Log.writeln(regionEnd.minus(1));
+    if (Options.verbose.getValue() > 2) {
+      Log.write("Mapping discontiguous spaces ");
+      Log.write(regionStart);
+      Log.write("->");
+      Log.writeln(regionEnd.minus(1));
+    }
     Mmapper.ensureMapped(getDiscontigStart(), pages);
   }