[rvm-issues] [jira] Closed: (RVM-907) Error in RVMArray bulk copy barrier logic

[Daniel F. (JIRA) <ji...@co...>]

     [ http://jira.codehaus.org/browse/RVM-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Frampton closed RVM-907.
-------------------------------

    Resolution: Fixed

Resolved in r16028.

> Error in RVMArray bulk copy barrier logic
> -----------------------------------------
>
>                 Key: RVM-907
>                 URL: http://jira.codehaus.org/browse/RVM-907
>             Project: RVM
>          Issue Type: Bug
>    Affects Versions: 3.1.1
>            Reporter: Eddie Aftandilian
>            Priority: Minor
>
> I have been working with the primitive write barriers in Jikes RVM 3.1.1, and I just noticed that there is a logical error in the bulk copy code in RVMArray.  At line 623, in the arrayCopy() method for byte arrays, there is this code:
> if (NEEDS_BOOLEAN_ASTORE_BARRIER || NEEDS_BOOLEAN_ALOAD_BARRIER) {
>   Offset srcOffset = Offset.fromIntZeroExtend(srcIdx);
>   Offset dstOffset = Offset.fromIntZeroExtend(dstIdx);
>   Barriers.byteBulkCopy(src, srcOffset, dst, dstOffset, len);
> } else {
> ...
> This code triggers the write barrier for bulk copying a byte array.  However, the if statement is for boolean arrays, not byte arrays.  
> It's a simple fix: Just replace BOOLEAN with BYTE in the first line above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira