Re: [rvm-research] Probabilistic Calling Context patch

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Chris Ryder has patches to fix this. He plans to submit these asap.

Richard

On 4 Apr 2009, at 10:02, Dingwen Yuan wrote:

> Hello all,
>
> Has anyone tried the patch "Probabilistic Calling Context".
> http://sourceforge.net/tracker/?func=detail&aid=1764965&group_id=128805&atid=723235
> I have applied it against the RVM version 2.4.6, but there are some  
> errors:
>
> patching file jikesrvm-2.4.6/MMTk/src/org/mmtk/plan/Plan.java
> patching file jikesrvm-2.4.6/MMTk/src/org/mmtk/plan/generational/ 
> Gen.java
> patching file jikesrvm-2.4.6/MMTk/src/org/mmtk/plan/generational/ 
> copying/GenCopy.java
> patching file jikesrvm-2.4.6/MMTk/src/org/mmtk/plan/semispace/SS.java
> patching file jikesrvm-2.4.6/MMTk/src/org/mmtk/utility/alloc/ 
> Allocator.java
> Hunk #2 FAILED at 258.
> 1 out of 3 hunks FAILED -- saving rejects to file
> jikesrvm-2.4.6/MMTk/src/org/mmtk/utility/alloc/Allocator.java.rej
> patching file jikesrvm-2.4.6/MMTk/src/org/mmtk/utility/statistics/ 
> Stats.java
> patching file jikesrvm-2.4.6/bin/jconfigure
> patching file jikesrvm-2.4.6/config/build/BaseAdaptiveGenCopy
> patching file jikesrvm-2.4.6/config/build/BaseAdaptiveMarkSweep
> patching file jikesrvm-2.4.6/rvm/src/vm/arch/intel/ 
> VM_StackframeLayoutConstants.java
> patching file jikesrvm-2.4.6/rvm/src/vm/arch/intel/assembler/ 
> VM_Assembler.in
> Hunk #2 FAILED at 371.
> 1 out of 2 hunks FAILED -- saving rejects to file
> jikesrvm-2.4.6/rvm/src/vm/arch/intel/assembler/VM_Assembler.in.rej
> patching file jikesrvm-2.4.6/rvm/src/vm/arch/intel/compilers/ 
> baseline/VM_BaselineExceptionDeliverer.java
> patching file jikesrvm-2.4.6/rvm/src/vm/arch/intel/compilers/ 
> baseline/VM_Compiler.java
> Hunk #2 FAILED at 2146.
> 1 out of 4 hunks FAILED -- saving rejects to file
> jikesrvm-2.4.6/rvm/src/vm/arch/intel/compilers/baseline/ 
> VM_Compiler.java.rej
> patching file jikesrvm-2.4.6/rvm/src/vm/classLoader/VM_Atom.java
> patching file jikesrvm-2.4.6/rvm/src/vm/classLoader/VM_Class.java
> patching file jikesrvm-2.4.6/rvm/src/vm/classLoader/VM_Member.java
> patching file jikesrvm-2.4.6/rvm/src/vm/classLoader/ 
> VM_MemberReference.java
> patching file jikesrvm-2.4.6/rvm/src/vm/classLoader/ 
> VM_TypeReference.java
> patching file jikesrvm-2.4.6/rvm/src/vm/compilers/baseline/ 
> VM_CompilerFramework.java
> patching file jikesrvm-2.4.6/rvm/src/vm/compilers/optimizing/driver/ 
> OPT_OptimizationPlanner.java
> patching file jikesrvm-2.4.6/rvm/src/vm/compilers/optimizing/ir/ 
> conversions/bc2hir/OPT_BC2IR.java
> patching file jikesrvm-2.4.6/rvm/src/vm/compilers/optimizing/ 
> optimizations/control/OPT_PCCInstr.java
> patching file jikesrvm-2.4.6/rvm/src/vm/compilers/optimizing/ 
> optimizations/global/ssa/codePlacement/OPT_LICM.java
> Hunk #1 FAILED at 673.
> 1 out of 1 hunk FAILED -- saving rejects to file
> jikesrvm-2.4.6/rvm/src/vm/compilers/optimizing/optimizations/global/ 
> ssa/codePlacement/OPT_LICM.java.rej
> patching file jikesrvm-2.4.6/rvm/src/vm/memoryManagers/JMTk/ 
> vmInterface/MM_Interface.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_DynamicLinker.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_Entrypoints.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_Magic.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_PCC.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_PCCStackTrace.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_Reflection.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_Runtime.java
> patching file jikesrvm-2.4.6/rvm/src/vm/runtime/VM_StackTrace.java
> patching file jikesrvm-2.4.6/rvm/src/vm/scheduler/MainThread.java
> patching file jikesrvm-2.4.6/rvm/src/vm/scheduler/VM_Processor.java
> patching file jikesrvm-2.4.6/rvm/src/vm/scheduler/VM_Thread.java
> patching file jikesrvm-2.4.6/rvm/src/vm/utility/BooleanOptions.dat
> patching file jikesrvm-2.4.6/rvm/src/vm/utility/VM_HashSet.java
> patching file jikesrvm-2.4.6/rvm/src/vm/utility/ValueOptions.dat
> patching file jikesrvm-2.4.6/rvm/src/vm/vmmagic/pragma/ 
> PragmaException.java
> patching file jikesrvm-2.4.6/tools/bootImageWriter/Makefile
>
> And when I tried to compile the patched rvm, I also got some
> compilation errors -
> jbuild.copy: (set up jbuild.prep.host) 7 s
> jbuild.compile: (compiling mmtk... mmtk compiled) (compiling  
> classes...
> Found 4 semantic errors compiling "com/ibm/JikesRVM/VM_PCC.java":
>
>    41. import com.ibm.JikesRVM.opt.VM_OptCompiledMethod;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptCompiledMethod" is not valid, since it
> does not name a type in a package.
>
>
>    42. import com.ibm.JikesRVM.opt.VM_OptEncodedCallSiteTree;
>               ^--------------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptEncodedCallSiteTree" is not valid, since
> it does not name a type in a package.
>
>
>    43. import com.ibm.JikesRVM.opt.VM_OptMachineCodeMap;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptMachineCodeMap" is not valid, since it
> does not name a type in a package.
>
>
>   813.     Node checkNode =
> VM_PCCStackTrace.computeNode(Address.zero(), prologue, skip + 1,
> print, false);
>                             ^--------------^
> *** Semantic Error: A candidate for type "VM_PCCStackTrace" was found,
> but it is invalid and needs to be fixed before this type will
> successfully compile.
>
> Found 1 semantic error compiling "java/lang/Throwable.java":
>
>    16. import com.ibm.JikesRVM.VM_StackTrace;
>                                ^-----------^
> *** Semantic Error: A candidate for type "VM_StackTrace" was found,
> but it is invalid and needs to be fixed before this type will
> successfully compile.
>
> Found 1 semantic error compiling "com/ibm/JikesRVM/VM_Runtime.java":
>
>    16. import com.ibm.JikesRVM.opt.VM_OptCompiledMethod;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptCompiledMethod" is not valid, since it
> does not name a type in a package.
>
> Found 1 semantic error compiling "java/lang/reflect/Method.java":
>
>    17. import com.ibm.JikesRVM.VM_Runtime;
>                                ^--------^
> *** Semantic Error: A candidate for type "VM_Runtime" was found, but
> it is invalid and needs to be fixed before this type will successfully
> compile.
>
> Found 3 semantic errors compiling "com/ibm/JikesRVM/ 
> VM_StackTrace.java":
>
>    18. import com.ibm.JikesRVM.opt.VM_OptCompiledMethod;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptCompiledMethod" is not valid, since it
> does not name a type in a package.
>
>
>    19. import com.ibm.JikesRVM.opt.VM_OptEncodedCallSiteTree;
>               ^--------------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptEncodedCallSiteTree" is not valid, since
> it does not name a type in a package.
>
>
>    20. import com.ibm.JikesRVM.opt.VM_OptMachineCodeMap;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptMachineCodeMap" is not valid, since it
> does not name a type in a package.
>
> Found 1 semantic error compiling
> "com/ibm/JikesRVM/memoryManagers/mmInterface/MM_Interface.java":
>
>    57. import com.ibm.JikesRVM.VM_PCC;
>                                ^----^
> *** Semantic Error: A candidate for type "VM_PCC" was found, but it is
> invalid and needs to be fixed before this type will successfully
> compile.
>
> Found 1 semantic error compiling "Dummy.java":
>
>    12. import  
> com.ibm.JikesRVM.memoryManagers.mmInterface.MM_Interface;
>                                                           ^----------^
> *** Semantic Error: A candidate for type "MM_Interface" was found, but
> it is invalid and needs to be fixed before this type will successfully
> compile.
>
> Found 1 semantic error compiling "com/ibm/JikesRVM/VM_Compiler.java":
>
>    29. public class VM_Compiler extends VM_BaselineCompiler
> implements VM_BaselineConstants, VM_SizeConstants {
>                     ^---------^
> *** Semantic Error: The abstract method "void
> emit_pcc_callsite_instrumentation 
> (com.ibm.JikesRVM.classloader.VM_MethodReference
> methodRef, boolean beforeCall);", inherited from type
> "com.ibm.JikesRVM.VM_CompilerFramework", is not implemented in the
> non-abstract class "com.ibm.JikesRVM.VM_Compiler".
>
> Found 12 semantic errors compiling "com/ibm/JikesRVM/ 
> VM_PCCStackTrace.java":
>
>     6. import com.ibm.JikesRVM.opt.VM_OptCompiledMethod;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptCompiledMethod" is not valid, since it
> does not name a type in a package.
>
>
>     7. import com.ibm.JikesRVM.opt.VM_OptEncodedCallSiteTree;
>               ^--------------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptEncodedCallSiteTree" is not valid, since
> it does not name a type in a package.
>
>
>     8. import com.ibm.JikesRVM.opt.VM_OptMachineCodeMap;
>               ^---------------------------------------^
> *** Semantic Error: The import
> "com/ibm/JikesRVM/opt/VM_OptMachineCodeMap" is not valid, since it
> does not name a type in a package.
>
>
>    47.           VM_OptCompiledMethod optcm =
> (VM_OptCompiledMethod)compiledMethod;
>                  ^------------------^
> *** Semantic Error: Type "VM_OptCompiledMethod" was not found.
>
>
>    47.           VM_OptCompiledMethod optcm =
> (VM_OptCompiledMethod)compiledMethod;
>                                                ^------------------^
> *** Semantic Error: Type "VM_OptCompiledMethod" was not found.
>
>
>    48.             VM_OptMachineCodeMap map = optcm.getMCMap();
>                    ^------------------^
> *** Semantic Error: Type "VM_OptMachineCodeMap" was not found.
>
>
>   158.           VM_OptCompiledMethod optcm =
> (VM_OptCompiledMethod)compiledMethod;
>                  ^------------------^
> *** Semantic Error: Type "VM_OptCompiledMethod" was not found.
>
>
>   158.           VM_OptCompiledMethod optcm =
> (VM_OptCompiledMethod)compiledMethod;
>                                                ^------------------^
> *** Semantic Error: Type "VM_OptCompiledMethod" was not found.
>
>
>   159.             VM_OptMachineCodeMap map = optcm.getMCMap();
>                    ^------------------^
> *** Semantic Error: Type "VM_OptMachineCodeMap" was not found.
>
>
>   252.           VM_OptCompiledMethod optcm =
> (VM_OptCompiledMethod)compiledMethod;
>                  ^------------------^
> *** Semantic Error: Type "VM_OptCompiledMethod" was not found.
>
>
>   252.           VM_OptCompiledMethod optcm =
> (VM_OptCompiledMethod)compiledMethod;
>                                                ^------------------^
> *** Semantic Error: Type "VM_OptCompiledMethod" was not found.
>
>
>   253.             VM_OptMachineCodeMap map = optcm.getMCMap();
>                    ^------------------^
> *** Semantic Error: Type "VM_OptMachineCodeMap" was not found.
> compilation FAILED) jbuild.compile: The Jikes compiler exited with  
> status 1
>     Run jbuild.compile -trace if you need more information
> jbuild.compile: Exiting unexpectedly with status 1.
> jbuild.compile:162: some command we just ran (probably with a
>     final argument of "unexpected_exit") exited with status 1,
>
> jbuild.compile: Aborting execution.
> 13 s
> jbuild: Trouble while running "./jbuild.compile " (exit status
>     1); aborting execution
>
>
> I wonder whether RVM 2.4.6 is the right version to patch against.
>
> Thanks in advance.
>
> Dingwen
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Jikesrvm-researchers mailing list
> Jik...@li...
> https://lists.sourceforge.net/lists/listinfo/jikesrvm-researchers

Richard Jones | Reader in Computer Systems | University of Kent
Computing Laboratory, University of Kent, Canterbury, Kent CT2 7NF, UK
T +44 1227 827943 | F +44 1227 762811 | W http://www.cs.kent.ac.uk/~rej/