[Jflight-dev] Redesign by Thomas

[Guido S. <gui...@ba...>]

Hi Tomas,
I have got your zip file from Rüdiger and first of all, I am impressed
by your Java coding style. But never the less I had to fix some issues
before JBuilder 3.5 was successfull under Linux to run the build:

1) The zip file unwraps to the following directory structure:

JFlight
JFlight/common
JFlight/database
JFlight/gps
JFlight/gui
JFlight/vario

Due to the case sensibility of Unix, JBuilder got in trouble with import
statements like "import jflight.gui.*" and some (?) files were not found.
After renaming the base directory to "jflight" it worked.

2) I was not able to guess were I have to place the FlightBook.fbk file
so the application can find it. I edited FlightBook.java and changed
line 549 to:

  in = new BufferedReader(new FileReader(System.getProperty("user.dir") +
         System.getProperty("file.separator") + "FlightBook.fbk"));

This was necessary because the application commandline arguments are not
handled yet.

3) I am not sure whether the lines 27 to 35 in GuiHandler.java make sense
because StringRes will contain the strings in the default language
en_US (-> typo in line 27). Line 33 should be replaced by an error
message to stdout, may be followed by an exit(1).


Concerning your design proposal I am not sure if it is to my taste,
because I would like more the old "one window style" with the
CardLayout. The old style is more common because it is often used in
other applocations. But I see also the advantage of your multi-window
style, because the overview may be better.

Your new directory/package strukture seems to be OK for me. How will
you take into account that we in future will have pure awt
frames/dialogs beside swing in the repository?  


At last let me explain what I am doing now. I concentrate on the old
ConfigurationPanel splitting/joining it into functional parts:

ConfigurationPanel --+--- SerialSetupDialog   done
                     |
                     +--- SerialAccess        in progress
                     |
                     +--- JFlight             done

Guido

-- 
mailto:gui...@ba...
http://www.bayernline.de/~gscholz/