jflac-developers — jFLAC developers mailing list

Re: [jflac-developers] Fork of the project + Maven Central publication

[Alex W. <ale...@gm...>]

Thank you, Nicolas; works well for me using Maven.

Best Regards,

Alex

On 2 September 2016 at 23:33, Nicolas Guillaumin <
nic...@gu...> wrote:

> For those interested, I've published my fork on Maven central:
>
> http://search.maven.org/#search%7Cga%7C1%7Cjflac
>
> Nicolas
>
> On Wed, Aug 24, 2016, at 18:51, Nicolas Guillaumin wrote:
> > Hi,
> >
> > I've been maintaining a fork of this project since a few years [1].
> > Initially it was because I had a fix [2] which was never merged, but
> > since then other people have made contributions [3].
> >
> > Somebody requested for my fork to be published on Maven central [4], and
> > I think that would be a good idea. The linked GitHub ticket discusses
> > various approaches and I wanted to know if you had any opinion on the
> > matter since I would like for the version published on Maven to be an
> > "official" one, with a proper groupId and artifactId, rather than just a
> > "fork". If the official version gets published later it would result in
> > confusion.
> >
> > I'd be happy to make my fork the official version if you don't want to
> > maintain the SourceForge project any more, but it would be best in that
> > case to take the SF project down to avoid confusion. If you'd prefer to
> > keep the official project at SourceForge, then we should try to find a
> > way to merge back the fixes on my fork into SourceForge. I'd be happy to
> > do that if you can grant me commit access to the repository. I'm also
> > open to any other suggestions.
> >
> > Let me know what you think?
> >
> > Nicolas
> >
> >
> > [1] https://github.com/nguillaumin/jflac
> > [2] https://sourceforge.net/p/jflac/patches/1/
> > [3] https://github.com/nguillaumin/jflac/pulls?q=is%3Apr+is%3Aclosed
> > [4] https://github.com/nguillaumin/jflac/issues/7
>
> ------------------------------------------------------------
> ------------------
> _______________________________________________
> jflac-developers mailing list
> jfl...@li...
> https://lists.sourceforge.net/lists/listinfo/jflac-developers
>

Re: [jflac-developers] Fork of the project + Maven Central publication

[Nicolas G. <nic...@gu...>]

For those interested, I've published my fork on Maven central:

http://search.maven.org/#search%7Cga%7C1%7Cjflac

Nicolas

On Wed, Aug 24, 2016, at 18:51, Nicolas Guillaumin wrote:
> Hi,
> 
> I've been maintaining a fork of this project since a few years [1]. 
> Initially it was because I had a fix [2] which was never merged, but 
> since then other people have made contributions [3].
> 
> Somebody requested for my fork to be published on Maven central [4], and 
> I think that would be a good idea. The linked GitHub ticket discusses 
> various approaches and I wanted to know if you had any opinion on the 
> matter since I would like for the version published on Maven to be an 
> "official" one, with a proper groupId and artifactId, rather than just a 
> "fork". If the official version gets published later it would result in 
> confusion.
> 
> I'd be happy to make my fork the official version if you don't want to 
> maintain the SourceForge project any more, but it would be best in that 
> case to take the SF project down to avoid confusion. If you'd prefer to 
> keep the official project at SourceForge, then we should try to find a 
> way to merge back the fixes on my fork into SourceForge. I'd be happy to 
> do that if you can grant me commit access to the repository. I'm also 
> open to any other suggestions.
> 
> Let me know what you think?
> 
> Nicolas
> 
> 
> [1] https://github.com/nguillaumin/jflac
> [2] https://sourceforge.net/p/jflac/patches/1/
> [3] https://github.com/nguillaumin/jflac/pulls?q=is%3Apr+is%3Aclosed
> [4] https://github.com/nguillaumin/jflac/issues/7

[jflac-developers] Fork of the project + Maven Central publication

[Nicolas G. <nic...@gu...>]

Hi,

I've been maintaining a fork of this project since a few years [1]. 
Initially it was because I had a fix [2] which was never merged, but 
since then other people have made contributions [3].

Somebody requested for my fork to be published on Maven central [4], and 
I think that would be a good idea. The linked GitHub ticket discusses 
various approaches and I wanted to know if you had any opinion on the 
matter since I would like for the version published on Maven to be an 
"official" one, with a proper groupId and artifactId, rather than just a 
"fork". If the official version gets published later it would result in 
confusion.

I'd be happy to make my fork the official version if you don't want to 
maintain the SourceForge project any more, but it would be best in that 
case to take the SF project down to avoid confusion. If you'd prefer to 
keep the official project at SourceForge, then we should try to find a 
way to merge back the fixes on my fork into SourceForge. I'd be happy to 
do that if you can grant me commit access to the repository. I'm also 
open to any other suggestions.

Let me know what you think?

Nicolas


[1] https://github.com/nguillaumin/jflac
[2] https://sourceforge.net/p/jflac/patches/1/
[3] https://github.com/nguillaumin/jflac/pulls?q=is%3Apr+is%3Aclosed
[4] https://github.com/nguillaumin/jflac/issues/7

[jflac-developers] Rice2 Residual Coding Method Support

[Alex W. <ale...@gm...>]

Hi all,

I want to firstly say thank you for your work on jFLAC - having a native
Java FLAC implementation is very nice.

Anyway, I was using the latest stable release (1.3.0) and noticed it
wouldn't decode a high-resolution (24 bit, 96 kHz) FLAC file I had - it
threw a lot of "STREAM_DECODER_UNPARSEABLE_STREAM" errors. Looking at the
source code from your Sourceforge git repo, I noticed the problem was
primarily a lack of support for the Rice2 residual coding method:
http://flac.sourceforge.net/format.html#rice2_partition (To reproduce the
error, you can re-encode "McDougalsMen24bit_48kHz.flac" in the test
resources using the latest version of flac (1.2.1) and try to play using
jFLAC.)

So I got the original FLAC source code for the latest version without Rice2
(1.1.4) and the current version (1.2.1) and did a diff on the
stream_decoder.c to find the required changes. The result being I've
updated jFLAC such that it can now play files which use the Rice2 encoding
method. Hence the purpose of this email, to ask if you would interested in
these changes (I made a new local git branch called flac-1.2.1 from the
master one, so it shouldn't be too hard to share that - I'm quite new to
git but I gather if I pushed it online someone could then process it?) or
are you focussing on the version 2.0 rewrite? It's not comprehensively
tested (and I also noticed that the seek code had been updated in FLAC
1.2.1 compared to 1.1.4 but it didn't look related) however it works
insofar as it successfully decodes all the FLAC files I have whereas the
current version does not.

Best Regards,

Alex

[jflac-developers] [ jflac-Bugs-3440700 ] "duration" and frameLength properties missing

[SourceForge.net <no...@so...>]

Bugs item #3440700, was opened at 2011-11-21 03:26
Message generated for change (Tracker Item Submitted) made by hendriks73
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=644732&aid=3440700&group_id=106536

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hendrik Schreiber (hendriks73)
Assigned to: Nobody/Anonymous (nobody)
Summary: "duration" and frameLength properties missing

Initial Comment:
AudioFileFormat allows the SPI implementation to expose certain properties like the duration and the frame length (in this case, number of sample frames in the file). In the current implementation these are missing. However, since both are present in the FLAC StreamInfo, they are very easy to provide and make jFlac that much more useful.

I wrote a corresponding patch. It's attached.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=644732&aid=3440700&group_id=106536