Menu
▾
▴
#1058 Define payment date for Payment
DO NOT EDIT OR ANSWER THIS ISSUE. SEE THE ORIGINAL ISSUE INSTEAD:
https://www.jfire.org/modules/bugs/view.php?id=1522
ORIGINAL REPORTER: alex
It should be possible for the user to define a date for a payment when he enters it in the system. This requires changes in the backend (set payment date later) and in the user interface (date-edit for the payment wizard etc.)
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Please, before starting with development of this task, start an evaluation of which parts would be influenced by the changes and create a plan of the things to be done.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Thinking of this a little more, it might be good to have both information in Payment: when the payment was entered into the system and when the payment was actually done by the customer.
What also needs to be taken into account is that Payment currently does not store only one date. It stores a beginDT and an endDT. So that payments that last a certain period like for example deferred payments that are later done in a batched automatic direct-debit can be modeled.
Imho beginDT and endDT should remain there and reflect the times the process started and ended in JFire (i.e. usually the time entering the payment into the system). Additionally we should have a date that reflects the time of the actual customer-payment. We might call that field 'paymentDT'.
I saw that Payment is also not sufficiently documented (at least the getters for the dates), this should also be done in this task.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Your opinion on paymentDT?
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Please, before starting with development of this task, start an evaluation of which parts would be influenced by the changes and create a plan of the things to be done.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Thinking of this a little more, it might be good to have both information in Payment: when the payment was entered into the system and when the payment was actually done by the customer.
What also needs to be taken into account is that Payment currently does not store only one date. It stores a beginDT and an endDT. So that payments that last a certain period like for example deferred payments that are later done in a batched automatic direct-debit can be modeled.
Imho beginDT and endDT should remain there and reflect the times the process started and ended in JFire (i.e. usually the time entering the payment into the system). Additionally we should have a date that reflects the time of the actual customer-payment. We might call that field 'paymentDT'.
I saw that Payment is also not sufficiently documented (at least the getters for the dates), this should also be done in this task.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Your opinion on paymentDT?
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
added payment date to both delivery and payment wizard pages
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Please, before starting with development of this task, start an evaluation of which parts would be influenced by the changes and create a plan of the things to be done.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Thinking of this a little more, it might be good to have both information in Payment: when the payment was entered into the system and when the payment was actually done by the customer.
What also needs to be taken into account is that Payment currently does not store only one date. It stores a beginDT and an endDT. So that payments that last a certain period like for example deferred payments that are later done in a batched automatic direct-debit can be modeled.
Imho beginDT and endDT should remain there and reflect the times the process started and ended in JFire (i.e. usually the time entering the payment into the system). Additionally we should have a date that reflects the time of the actual customer-payment. We might call that field 'paymentDT'.
I saw that Payment is also not sufficiently documented (at least the getters for the dates), this should also be done in this task.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Your opinion on paymentDT?
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
added payment date to both delivery and payment wizard pages
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Reviewed the UI and the code and have to reopen:
1. When I enter a payment-Date different than the current date
it is reflected in the UI but that value never makes it into the datastore.
I'm not sure why, maybe another Payment instance is persisted and needs to
be configured correctly or some thing else is wrong.
The new Payment EditorPage show this error clearly by the way ther is no
need to check the database.
2. When I checked the UI, another thing came into my mind. The UI lets the
user choose a date, but the value stored has also time information.
The user should be able to define the time as well. It should default to the
current time, but should be selectable.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Erm, sorry, have to revise: The user is able to select the time, so forget about the second point...
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Think I've found it:
Payment has the method cloneForUpload(), there the paymentDT was not copied.
@Fitas: Have you ever tested this before closing?
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Ok, verified. It was the clone-method. Payment-Dates are now correctly written.
So there is only one thing left: Documentation.
Please document the difference between the payment dates (beginDT, endDT and paymentDT) in the Java-Doc of the resp. getters.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Please, before starting with development of this task, start an evaluation of which parts would be influenced by the changes and create a plan of the things to be done.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Thinking of this a little more, it might be good to have both information in Payment: when the payment was entered into the system and when the payment was actually done by the customer.
What also needs to be taken into account is that Payment currently does not store only one date. It stores a beginDT and an endDT. So that payments that last a certain period like for example deferred payments that are later done in a batched automatic direct-debit can be modeled.
Imho beginDT and endDT should remain there and reflect the times the process started and ended in JFire (i.e. usually the time entering the payment into the system). Additionally we should have a date that reflects the time of the actual customer-payment. We might call that field 'paymentDT'.
I saw that Payment is also not sufficiently documented (at least the getters for the dates), this should also be done in this task.
ORIGINAL COMMENT BY fitas_java, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
added payment date to both delivery and payment wizard pages
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Your opinion on paymentDT?
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Reviewed the UI and the code and have to reopen:
1. When I enter a payment-Date different than the current date
it is reflected in the UI but that value never makes it into the datastore.
I'm not sure why, maybe another Payment instance is persisted and needs to
be configured correctly or some thing else is wrong.
The new Payment EditorPage show this error clearly by the way ther is no
need to check the database.
2. When I checked the UI, another thing came into my mind. The UI lets the
user choose a date, but the value stored has also time information.
The user should be able to define the time as well. It should default to the
current time, but should be selectable.
ORIGINAL COMMENT BY alex, VIEW IT HERE:
https://www.jfire.org/modules/bugs/view.php?id=1522
Erm, sorry, have to revise: The user is able to select the time, so forget about the second point...