[jetty-discuss] [ jetty-Bugs-1431255 ] Jetty6: continuation retained when Request recycled

[SourceForge.net <no...@so...>]

Bugs item #1431255, was opened at 2006-02-14 01:11
Message generated for change (Comment added) made by petenewcomb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=107322&aid=1431255&group_id=7322

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Other
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Submitted By: Peter Newcomb (petenewcomb)
Assigned to: Greg Wilkins (gregwilkins)
Summary: Jetty6: continuation retained when Request recycled

Initial Comment:
When a Request object is recycled, its _continuation
field is not reset.  The symptom I noticed is that
sometimes ContinuationSupport.getContinuation(), when
passed a brand-new  request object, returns a
continuation for which isNew() returns false.

Patch to fix:

Index:
modules/jetty/src/main/java/org/mortbay/jetty/Request.java
===================================================================
---
modules/jetty/src/main/java/org/mortbay/jetty/Request.java
(revision 211)
+++
modules/jetty/src/main/java/org/mortbay/jetty/Request.java
(working copy)
@@ -147,6 +147,7 @@
         _inputState=__NONE;
         _reader=null; 
         _cookiesExtracted=false;
+        _continuation=null;
         if (_savedNewSessions!=null)
             _savedNewSessions.clear();
         _savedNewSessions=null;


----------------------------------------------------------------------

>Comment By: Peter Newcomb (petenewcomb)
Date: 2006-02-14 15:45

Message:
Logged In: YES 
user_id=1415278

I was using my own build of trunk (revision 211), but I just
tried it with beta9 and had the same problem.  Once I put
the above patch into my build, it works as expected.

----------------------------------------------------------------------

Comment By: Greg Wilkins (gregwilkins)
Date: 2006-02-14 12:36

Message:
Logged In: YES 
user_id=44062

I believe this has been fixed in beta9.  The continuation is 
recycled (ie not set to zero), so the fix was to make the 
continuation implementations reusable, not to null it.

but thanks anyway for the report and patch.




----------------------------------------------------------------------

Comment By: Greg Wilkins (gregwilkins)
Date: 2006-02-14 12:17

Message:
Logged In: YES 
user_id=44062

I believe this has been fixed in beta9.  The continuation is 
recycled (ie not set to zero), so the fix was to make the 
continuation implementations reusable, not to null it.

but thanks anyway for the report and patch.




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=107322&aid=1431255&group_id=7322