[jetty-discuss] Re: Bug in org.mortbay.start.Main ?

[Greg W. <gr...@mo...>]

thanks. 

I think it is best to expand the subject early anyway.


Tzvetan Mikov wrote:
> Hi,
> I think is may be a bug, but since I am new to the Jetty community, I 
> didn't want to go submitting bug reports right away.
> 
> I noticed that the format of each line in start.config is checked before 
> it is variable-expanded. This appliies in particular to the usage of 
> "jetty.class.path".
> 
> The line is in start.config is:
> $(jetty.class.path)                              always
> 
> Main.configure() checks it for various conditions (whether it ends with 
> "/" or "/*", etc) _before_ it has been expanded; obviously this line 
> can't satisfy any of the conditions. It falls to the default case of 
> representing a single JAR file.
> 
> I don't know whether the intention of "jetty.class.path" is to hold just 
> one JAR file - that seems pretty pointless to me.
> 
> The fix for more consistent behavior is relatively easy. I am attaching 
> the patch for  org.mortbay.start.Main.java. Note that I haven't tested it.
> 
> 
> ------------------------------------------------------------------------
> 
> --- Main.java	2004-11-23 10:30:22.000000000 -0800
> +++ Main.new.java	2005-03-21 17:27:14.814505600 -0800
> @@ -288,7 +288,8 @@
>                      expression&=not?!eval:eval;
>                      not=false;
>                  }
> -                String file=expand(subject).replace('/',File.separatorChar);
> +                subject=expand(subject);
> +                String file=subject.replace('/',File.separatorChar);
>                  if(_debug)
>                      System.err.println((expression?"T ":"F ")+line);
>                  if(!expression)