Re: [jetty-discuss] possible bug in servlet handling

[Jan B. <ja...@mo...>]

Ulf,

Ulf Ochsenfahrt wrote:
> Jan Bartel wrote:
>> You need to provide a unique name for each instance of the
>> ServletHolder, because you are effectively declaring the
>> same servlet class twice. This is exactly equivalent to declaring the
>> <name> element of a <servlet> in a web.xml file (the <name>
>> element being mandatory).
> 
> I havn't written web.xml files before, nor does it anything about the
> name in the documentation.
Ah, well, the web.xml is defined in the Servlet Specification, currently
up to version 2.5 and available from here http://jcp.org/en/jsr/detail?id=154
I think it would generally be a good idea if you're familiar with the spec and
the contents of the web.xml file, even if you intend to use jetty embedded.

>> So do:
>>
>>
>>         Context context = new Context(server,"/",Context.SESSIONS);
>>         ServletHolder a = new ServletHolder(new HelloServlet("Ciao1"));
>>         a.setName("Ciao1");
>>         context.addServlet(a, "*.x");
>>         ServletHolder b = new ServletHolder(new HelloServlet("Ciao2"));
>>         b.setName("Ciao2");
>>         context.addServlet(b, "*.y");
>>
>> Note that if you use 2 different servlet classes, you won't need to
>> explicitly set the name, because jetty will use the name of the class
>> as the
>> unique name.
> 
> Jay, that works. But wouldn't it be smarter if the ServletHolder used
> not just the class name, but also an object specific value (such as the
> system hash code)? Or at least say in the documentation somewhere that a
> unique name must be set? Maybe even provide a ServletHolder constructor
> that takes an additional String?
I think you're the first person that I've ever heard of to use the 
same servlet twice. Certainly never had any other reports of this
on these lists. But, I take your point. Your wish is my command. 
See revision 1391 of svn trunk.


regards
Jan

> 
> Thanks,
> 
> -- Ulf
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> jetty-discuss mailing list
> jet...@li...
> https://lists.sourceforge.net/lists/listinfo/jetty-discuss