[jetty-discuss] [jira] Created: (JETTY-124) ServletHolder assumes all filters are registered before init is called: inconsistent with geronimo integration

[David J. (JIRA) <ji...@co...>]

ServletHolder assumes all filters are registered before init is called: inconsistent with geronimo integration
--------------------------------------------------------------------------------------------------------------

                 Key: JETTY-124
                 URL: http://jira.codehaus.org/browse/JETTY-124
             Project: Jetty
          Issue Type: Bug
          Components: Servlet
    Affects Versions: 6.0.1
            Reporter: David Jencks


The geronimo integration assumes that filters (or maybe filter mappings) can be registered with a servlet after the servlet starts.  The jetty runtime code assumes this too, but the jetty startup code doesn't.  Here's a patch that fixes the startup code:

Index: modules/jetty/src/main/java/org/mortbay/jetty/servlet/ServletHandler.java
===================================================================
--- modules/jetty/src/main/java/org/mortbay/jetty/servlet/ServletHandler.java   (revision 979)
+++ modules/jetty/src/main/java/org/mortbay/jetty/servlet/ServletHandler.java   (working copy)
@@ -141,7 +141,7 @@
         if (isInitializeAtStart())
             initialize();
 
-        if(_filterChainsCached && _filters!=null && _filters.length>0)
+        if(_filterChainsCached)
         {
             _chainCache=     new HashMap[]{null,new HashMap(),new HashMap(),null,new HashMap(),null,null,null,new HashMap()};
             _namedChainCache=new HashMap[]{null,null,new HashMap(),null,new HashMap(),null,null,null,new HashMap()};


The runtime code that gets into trouble without this patch is in getFilterChain around line 479:

        if (_filterChainsCached)
        {
            synchronized(this)
            {
                if (LazyList.size(filters) > 0)
                    chain= new CachedChain(filters, servletHolder);
                if (_maxFilterChainsCacheSize>0 && _chainCache[requestType].size()>_maxFilterChainsCacheSize)
                    _chainCache[requestType].clear();
                _chainCache[requestType].put(key,chain);
            }
        }


As you can see, if filterChainsCached is true you can get into trouble with _chainCache being null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira