Patch for MacOSX integration without plugin

jEdit is a programmer's text editor written in Java.

Brought to you by: daleanson, ezust, grepppo, k_satoda, and 5 others

#624 Patch for MacOSX integration without plugin

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2020-11-30

Created: 2019-08-19

Creator: Heklaz

Private: No

Patch for MacOSX

Against latest trunk

Removes the need for MacOSX plugin - removed from build.xml and ivy.xml
Removes some keyboard binding errors (on Macosx anyway - can't check on Windows)
Integrates to MacOSX using java.awt.Desktop in org/gjt/sp/jedit/View.java

Tested on MacOSX and Linux.

1 Attachments

macosx.patch

Discussion

Heklaz - 2019-08-21

Requires at least Java 9.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Makarius - 2020-06-09

This is a more concise patch. It is also closer to the plugin MacOS 1.5 (by makarius).

The plugin has Desktop.setOpenFileHandler but it seems to be unnecessary: drag&drop of files onto the view works without it.

Last edit: Makarius 2020-06-09

a.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Matthieu Casanova - 2020-06-09

I quickly checked, it seems good to me but I can't test, so if someone can test it, it would be cool, otherwise I will apply it.
Here is another patch, exactly the same with a few fixes in coding style

OSX_patch.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Makarius - 2020-06-10
  
  This is now in jedit-trunk r25349.
  
  This is vacuous for Linux and Windows: conditions like desktop.isSupported(Action.APP_QUIT_HANDLER) are false.
  
  It works fine on macOS Catalina 10.15.5, with or without the MacOS plugin (the MacOSX plugin is for old Java 8). Can someone who understands the ant setup remove all references to the MacOSX plugin from it?
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Makarius - 2020-06-09

Looks good. If you apply it, I will test it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dale Anson - 2020-06-09

Here's a jar with jEdit from head with the patch attached:

https://drive.google.com/open?id=1ZZNNqLaN27ZB8RxKEMe-SbEdTMB4UEPD

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Makarius - 2020-06-10
  
  I have now learned to use "ant dist", so I won't need any further build snapshots.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Heklaz - 2020-06-22
  
  Seems to work fine on Macos and Windows 10
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Peter Lynch - 2020-11-30

@makarius

Can someone who understands the ant setup remove all references to the MacOSX plugin from it?

Attached is a patch against SVN revision 25386 that removes references to the MacOSX.jar from the build/ivy files.

Last edit: Peter Lynch 2020-11-30

remove-MacOSX-jar-plugin-references-svn.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Makarius - 2020-11-30

I don't understand the ant setup.

Maybe it is better to make a separate tracker item to get more attention for the patch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Peter Lynch - 2020-11-30

@makarius ok - I created https://sourceforge.net/p/jedit/patches/627/ for my patch.

Meanwhile, what is the reason this patch issue is still open?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.