[ jEdit-devel ] [ jedit-Plugin Patches-1854413 ] [Console] fix bug in capture of extra line for error

[SourceForge.net <no...@so...>]

Plugin Patches item #1854413, was opened at 2007-12-19 12:56
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=1854413&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Priority: 5
Private: No
Submitted By: David Bernard (dwayneb)
Assigned to: Alan Ezust (ezust)
Summary: [Console] fix bug in capture of extra line for error

Initial Comment:
CommandOutputParser add Error just after creation, so extraMessages aren't injected into ErrorList (doc set explicitly that adding extra must be done before adding Error).



----------------------------------------------------------------------

>Comment By: Alan Ezust (ezust)
Date: 2007-12-31 13:55

Message:
Logged In: YES 
user_id=935841
Originator: NO

right you are... This was the problem:
===================================================================
--- plugins/Console/trunk/console/StreamThread.java     2007-12-31
20:09:58 UTC (rev 11494)
+++ plugins/Console/trunk/console/StreamThread.java     2007-12-31
21:51:25 UTC (rev 11495)
@@ -175,6 +175,7 @@
               }
               finally
               {
+                       copt.finishErrorParsing();
                       try
                       {
                               in.close();

Committed revision 11495. Thanks again --alan


----------------------------------------------------------------------

Comment By: David Bernard (dwayneb)
Date: 2007-12-31 13:14

Message:
Logged In: YES 
user_id=103936
Originator: YES

You're right, I didn't check with the ConsoleOutput of shell system.
I only test with my custom ConsoleOutput, that call "finishErrorParsing()"
at the end (in this case the last error is displayed). I though that is the
normal way.

What is the best place to call finishErrorParsing() (I'm not the author of
the method, it already exists) ?

Thanks

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2007-12-31 12:17

Message:
Logged In: YES 
user_id=935841
Originator: NO

I'm testing this patch and it's not quite right yet... I find that if the
last (or only) error is a single line error message,
it never gets added to ErrorList.


----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2007-12-31 12:17

Message:
Logged In: YES 
user_id=935841
Originator: NO

I'm testing this patch and it's not quite right yet... I find that if the
last (or only) error is a single line error message,
it never gets added to ErrorList.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=1854413&group_id=588