Menu
▾
▴
jedit-devel
|
From: Matthieu C. <cho...@gm...> - 2006-07-07 22:38:40
|
Hi, I just committed Beanshell 2.0b4 inside jEdit. I did this two weeks ago and am using jEdit with that beanshell version, but I was waiting for pre5 release to commit that to have time to do long tests. So anybody who wants to try it can compile CVS head. I tagged jEdit before and after the commit. This is a modified version of beanshell for jEdit's use. The changes in the beanshell sources are only in NameSpace.java and I surrounded them with explicit fold. You can check the running version of beanshell in jEdit by executing beanshell command Interpreter.VERSION. If you have any bug using this, tell me Matthieu |
|
From: Marcelo V. <va...@us...> - 2006-07-08 02:41:00
|
Matthieu Casanova wrote: > Hi, I just committed Beanshell 2.0b4 inside jEdit. Is there any reason why we can't just ship the BeanShell jar with jEdit, instead of having its source code checked into CVS? If we *really* need to modify files, we can have only those files in the jEdit code base (and the ordering of the Java classpath should make sure we're loading the class file we want). -- Marcelo Vanzin va...@us... "Life is too short to drink cheap beer" |
|
From: Matthieu C. <cho...@gm...> - 2006-07-08 07:44:36
|
One reason could be that since we modify some classes, if we just add Beanshell to the classpath we will not be sure that the version in the classpath is the good one. And what would be our benefit in not bundling beanshell ? 2006/7/8, Marcelo Vanzin <va...@us...>: > > Matthieu Casanova wrote: > > Hi, I just committed Beanshell 2.0b4 inside jEdit. > > Is there any reason why we can't just ship the BeanShell jar with jEdit, > instead of having its source code checked into CVS? > > If we *really* need to modify files, we can have only those files in the > jEdit code base (and the ordering of the Java classpath should make sure > we're loading the class file we want). > > -- > Marcelo Vanzin > va...@us... > "Life is too short to drink cheap beer" > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > -- > ----------------------------------------------- > jEdit Developers' List > jEd...@li... > https://lists.sourceforge.net/lists/listinfo/jedit-devel > |
|
From: Marcelo V. <va...@us...> - 2006-07-08 18:06:57
|
Matthieu Casanova wrote: > One reason could be that since we modify some classes, if we just > add Beanshell to the classpath we will not be sure that the version in > the classpath is > the good one. > And what would be our benefit in not bundling beanshell ? Just to avoid having source code from other projects inside the jedit source tree. Aside from the small modifications you mentioned, I don't think we even touch the BeanShell code at all, so why have it in the repository? -- Marcelo Vanzin va...@us... "Life is too short to drink cheap beer" |
|
From: Slava P. <sl...@fa...> - 2006-07-08 18:38:52
|
On 8-Jul-06, at 2:08 PM, Marcelo Vanzin wrote: > Matthieu Casanova wrote: >> One reason could be that since we modify some classes, if we just >> add Beanshell to the classpath we will not be sure that the >> version in >> the classpath is >> the good one. >> And what would be our benefit in not bundling beanshell ? > > Just to avoid having source code from other projects inside the jedit > source tree. Aside from the small modifications you mentioned, I don't > think we even touch the BeanShell code at all, so why have it in the > repository? Convenience. If Java had something like asdf-install (Lisp) or gems (Ruby), it would be a simple matter of entering one command to download and install a dependency. However right now, a developer has to hunt down and install them manually, and it can be a bit of a hassle. Slava |
|
From: Marcelo V. <va...@us...> - 2006-07-08 22:02:11
|
Slava Pestov wrote: > Convenience. If Java had something like asdf-install (Lisp) or gems > (Ruby), it would be a simple matter of entering one command to > download and install a dependency. However right now, a developer has > to hunt down and install them manually, and it can be a bit of a hassle. Why can't we use Ant's "get" task to download the file? Then the only hassle is to change the build file in case beanshell's jar file moves on their server, or when we want a different version... -- Marcelo Vanzin va...@us... "Life is too short to drink cheap beer" |
|
From: Slava P. <sl...@fa...> - 2006-07-08 22:08:21
|
This would be even more work than having the source tree in CVS. Slava On 8-Jul-06, at 6:03 PM, Marcelo Vanzin wrote: > Slava Pestov wrote: >> Convenience. If Java had something like asdf-install (Lisp) or gems >> (Ruby), it would be a simple matter of entering one command to >> download and install a dependency. However right now, a developer has >> to hunt down and install them manually, and it can be a bit of a >> hassle. > > Why can't we use Ant's "get" task to download the file? Then the only > hassle is to change the build file in case beanshell's jar file > moves on > their server, or when we want a different version... > > -- > Marcelo Vanzin > va...@us... > "Life is too short to drink cheap beer" > > > ---------------------------------------------------------------------- > --- > Using Tomcat but need to do more? Need to support web services, > security? > Get stuff done quickly with pre-integrated technology to make your > job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > http://sel.as-us.falkag.net/sel? > cmd=lnk&kid=120709&bid=263057&dat=121642 > -- > ----------------------------------------------- > jEdit Developers' List > jEd...@li... > https://lists.sourceforge.net/lists/listinfo/jedit-devel |
|
From: Marcelo V. <va...@us...> - 2006-07-08 22:19:35
|
Let's agree to disagree then, since I don't agree with that statement. In my opinion the best solution would be to find a way to make the changes we need generic enough so they can be integrated into the mainline BeanShell distribution so we're able to use the jars without *any* modifications, and no need for any of their code in jEdit's tree. But that's just me. Slava Pestov wrote: > This would be even more work than having the source tree in CVS. > > Slava > > On 8-Jul-06, at 6:03 PM, Marcelo Vanzin wrote: > >> Slava Pestov wrote: >>> Convenience. If Java had something like asdf-install (Lisp) or gems >>> (Ruby), it would be a simple matter of entering one command to >>> download and install a dependency. However right now, a developer has >>> to hunt down and install them manually, and it can be a bit of a >>> hassle. >> Why can't we use Ant's "get" task to download the file? Then the only >> hassle is to change the build file in case beanshell's jar file >> moves on >> their server, or when we want a different version... -- Marcelo Vanzin va...@us... "Life is too short to drink cheap beer" |
|
From: Matthieu C. <cho...@gm...> - 2006-07-10 07:54:53
|
2006/7/9, Marcelo Vanzin <va...@us...>: > > Let's agree to disagree then, since I don't agree with that statement. > > In my opinion the best solution would be to find a way to make the > changes we need generic enough so they can be integrated into the > mainline BeanShell distribution so we're able to use the jars without > *any* modifications, and no need for any of their code in jEdit's tree. > > But that's just me. > In fact I tried to extend NameSpace instead of changing it, but that's too complicated because I can instantiate mine, but there is no factory to create them so when it is instantiated inside Beanshell it doesn't work. |
|
From: Marcelo V. <va...@us...> - 2006-07-11 02:33:38
|
Matthieu Casanova wrote: > In fact I tried to extend NameSpace instead of changing it, but that's > too complicated because I can instantiate mine, but there is no factory > to create them so when it is instantiated inside Beanshell it doesn't work. I guess what I wanted to know is, what are the changes needed to NameSpace to make it suitable for use within jEdit? Can we make those changes in a way that won't break Beanshell when it's not run inside jEdit, so the change can be submitted to the Beanshell maintainers? Even if that requires a little change in other places inside jEdit, I think it would be worth investigating. -- Marcelo Vanzin va...@us... "Life is too short to drink cheap beer" |
|
From: Matthieu C. <cho...@gm...> - 2006-07-11 05:54:20
|
2006/7/11, Marcelo Vanzin <va...@us...>: > > Matthieu Casanova wrote: > > In fact I tried to extend NameSpace instead of changing it, but that's > > too complicated because I can instantiate mine, but there is no factory > > to create them so when it is instantiated inside Beanshell it doesn't > work. > > I guess what I wanted to know is, what are the changes needed to > NameSpace to make it suitable for use within jEdit? > > Can we make those changes in a way that won't break Beanshell when it's > not run inside jEdit, so the change can be submitted to the Beanshell > maintainers? Even if that requires a little change in other places > inside jEdit, I think it would be worth investigating. > Hi, you can see the changes I surrounded them with explicit fold Matthieu |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X