Menu

#1250 Fix for pr3557493

closed-accepted
nobody
5
2012-08-22
2012-08-17
No

defparam assignments found inside a generate block were being stored in the enclosing module scope. They should be stored in the generate block scope.

In passing, I've also removed the genvar list from the PGenerate class, as this is now declared in the base LexicalScope class.

Patches for both devel and v0.9 attached, along with a regression test to add to the test suite. The test doesn't need any special compiler flags or a gold file.

Discussion

  • Martin Whitaker

    Martin Whitaker - 2012-08-17

    Proposed patch for devel

     
  • Martin Whitaker

    Martin Whitaker - 2012-08-17

    Proposed patch for v0.9

     
  • Martin Whitaker

    Martin Whitaker - 2012-08-17

    Regression test for test suite

     
  • Cary R.

    Cary R. - 2012-08-22

    I'm going to apply and push these shortly.

    One note on the copyright statements. We have in the past just made these ranges instead of marking individual years for example 2006-2010,2012 would be 2006-2012.

     
  • Cary R.

    Cary R. - 2012-08-22

    These have been applied.

     
  • Cary R.

    Cary R. - 2012-08-22
    • status: open --> closed-accepted
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.