Menu

#2018 Wrong icon path for class 'ServiceSubcategory'

3.0.1
closed
None
User Interface
Medium
3.0.0
defect
2022-01-20
2022-01-19
hong
No

Hi,
I found that there is a little mistake for the icon path of class 'ServiceSubcategory'. The definition in web/datamodels/2.x/itop-service-mgmt-provider.xml line 1387 is "<icon>../../images/icons/icons8-service</icon>" now. Thus there is a problem to show icon for 'ServiceSubcategory' in console UI. Should it be "<icon>../../images/icons/icons8-services.svg</icon>"?

1 Attachments

Related

Discussion: Link for "Service Subcategories" icon is broken

Discussion

  • Guillaume Lajarige

    • status: new --> accepted
    • assigned_to: Guillaume Lajarige
    • Milestone: 3.1.0 --> 3.0.1
     
  • Guillaume Lajarige

    Hello Hong,

    Thanks for pointing that out! I'll fix it right away, it will be part of the 3.0.1.

    Cheers,
    Guillaume

     
  • Pierre Goiffon

    Pierre Goiffon - 2022-01-19
    • assigned_to: Guillaume Lajarige --> Pierre Goiffon
    • Milestone: 3.0.1 --> 3.1.0
     
  • Pierre Goiffon

    Pierre Goiffon - 2022-01-19
    • assigned_to: Pierre Goiffon --> Guillaume Lajarige
     
  • Hipska

    Hipska - 2022-01-19

    @pgoiffon Why not 3.0.1? Seems like a minor fix/patch?

     
    😕
    1
  • Pierre Goiffon

    Pierre Goiffon - 2022-01-19

    Cause Guillaume and I did the modification at the very same moment :/
    I'll revert to 3.0.1

     
    😄
    1

    Last edit: Pierre Goiffon 2022-01-19
  • Pierre Goiffon

    Pierre Goiffon - 2022-01-19
    • Milestone: 3.1.0 --> 3.0.1
     
  • Guillaume Lajarige

    It's fixed in https://github.com/Combodo/iTop/commit/81c0951c2a0b1d6b7093376bbdee42db46fb0383 and will be part of the 3.0.1 (no release date yet)

    Can you send me your fullname and postal address by PM? We'll send you contributors stickers :)

    Thanks
    Guillaume

     
    👍
    1
    • hong

      hong - 2022-01-19

      Hi Guillaume,

      Thanks for the comment in GitHub, my full name is ‘Chen Hong’ but I think ‘Hong’ is totally ok for me! And you may not send me stickers since it is a really tiny contribution and also I have already received the collection of your stickers once (Yeah!).

      祝工作顺利~ Best regards~ ヾ(๑╹◡╹)ノ"

      陈红 Chen Hong

       
      ❤️
      1

      Last edit: Guillaume Lajarige 2022-01-19
      • Guillaume Lajarige

        Hello Chen,

        So sorry about the misunderstanding with your name! Once again thanks for the feedback and glad you enjoyed the stickers! :D

        Have a nice day,
        Guillaume

         

        Last edit: Guillaume Lajarige 2022-01-19
  • Guillaume Lajarige

    • status: accepted --> closed
    • assigned_to: Guillaume Lajarige --> Pierre Goiffon
     
  • Pierre Goiffon

    Pierre Goiffon - 2022-01-20

    Just to add Combodo internal tracker ref : N°4694

     

Log in to post a comment.

MongoDB Logo MongoDB
Gen AI apps are built with MongoDB Atlas
Atlas offers built-in vector search and global availability across 125+ regions. Start building AI apps faster, all in one place.