Menu

#1854 CompileBranding shouldn't consider line breaks inside tags as relevant

3.1.0
closed
nobody
None
fixed
Extension
Medium
2.6.1
defect
2023-06-19
2020-03-24
No

When compiling the branding section inside an extension, if you specify an image file on a line by its own, if will look for a filename with the line breaks, e.g.

<main_logo _delta="define>
   my-extension/images/my-logo.png
</main_logo>   

the file it looks for is \rmy-extension/images/my-logo.png\r which of course doesn't exist and the error message is misleading (it's not easy to see that the filename is wrong since one mentally removes the line breaks).
Line breaks right after the opening tag and right before the closing tag shouldn't be significant.
See also this message in the forum.

Discussion

  • Guillaume Lajarige

    Hello Luca,

    Thank you for taking the time of creating this ticket. I'll upload it in our bu tracker

    Cheers,
    Guillaume

     
  • Guillaume Lajarige

    • status: new --> to-be-reviewed
     
  • Guillaume Lajarige

    Logged as #2883.

     
  • Timothée Callet

    • status: to-be-reviewed --> closed
    • Milestone: Unassigned --> 3.1.0
    • Resolution: --> fixed
     
  • Timothée Callet

    Fixed in 3.1.0-beta released today

     

Log in to post a comment.